Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2098323003: Reduce generic warnings shown on dmg downloads (Closed)

Created:
4 years, 5 months ago by Jialiu Lin
Modified:
4 years, 5 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce generic warnings shown on dmg downloads. Old behaviors: (1) if dmg is successfully analyzed and has no executable inside, chrome shows the generic warning; (2) if dmg analysis fails, and the user is not a safe browsing extended reporting user (or in incognito mode), chrome shows generic warning without asking SB backend. New behaviors: (1) if dmg is successfully analyzed and has no executable inside, chrome regards it as SAFE. (2) if dmg analysis fails, send ping to SB backend and let it decide. BUG=621936 Committed: https://crrev.com/3c9ad45a9517df20e14c1a902922615f838d35cd Cr-Commit-Position: refs/heads/master@{#402551}

Patch Set 1 : dmg without executable is safe #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 8 chunks +48 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jialiu Lin
4 years, 5 months ago (2016-06-28 01:36:25 UTC) #7
Nathan Parker
lgtm
4 years, 5 months ago (2016-06-28 19:09:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098323003/2
4 years, 5 months ago (2016-06-28 20:04:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:2)
4 years, 5 months ago (2016-06-28 21:38:14 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:39:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c9ad45a9517df20e14c1a902922615f838d35cd
Cr-Commit-Position: refs/heads/master@{#402551}

Powered by Google App Engine
This is Rietveld 408576698