[gn] Use one source of truth for test source files.

[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921
Committed: https://crrev.com/994dc21148e08da0e4986f1f4a118dd69d05a8b3
Cr-Commit-Position: refs/heads/master@{#37331}

[Michael Achenbach, 2016-06-27 11:33:23]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 11:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-06-27 11:38:17]

Description was changed from

==========
[gn] Use one source of truth for test source files.

BUG=
==========

to

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

BUG=chromium:474921
==========

[Michael Achenbach, 2016-06-27 11:38:17]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-27 11:40:19]

PTAL. Requires adding an execute_script whitelisting in chromium first :/

https://codereview.chromium.org/2098313002/diff/60001/test/unittests/unittest...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/2098313002/diff/60001/test/unittests/unittest...
test/unittests/unittests.gyp:188: '<@(unittests_sources_mips)',
Making the same simplifications as in current BUILD.gn file as the same sources
are used for mips+mipsel and a bunch of others.

https://codereview.chromium.org/2098313002/diff/60001/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

https://codereview.chromium.org/2098313002/diff/60001/tools/gcmole/gcmole.lua...
tools/gcmole/gcmole.lua:190: { "test/cctest/cctest.gyp", "'(test-[^']-%.cc)'",
"test/cctest/" }
Added to my long-term todo to:
1) Activate unittests
2) Remove the test- restriction from cctest files

[commit-bot: I haz the power, 2016-06-27 11:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:41:25]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Achenbach, 2016-06-27 11:41:33]

Description was changed from

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

BUG=chromium:474921
==========

to

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921
==========

[jochen (gone - plz use gerrit), 2016-06-27 11:48:13]

i like it, lgtm

[Michael Achenbach, 2016-06-27 15:01:53]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:02:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 15:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 15:04:00]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8015)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7997)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/7975)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18109)

[Michael Achenbach, 2016-06-27 15:26:23]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:26:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 15:49:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 15:49:22]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-06-28 12:59:28]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-06-28 12:59:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2098313002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 12:59:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 13:22:54]

Description was changed from

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921
==========

to

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-06-28 13:22:55]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-28 13:24:19]

Description was changed from

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921
==========

to

==========
[gn] Use one source of truth for test source files.

This avoids forgetting to add files for either gyp or gn.

While for most executables, this is detected by compilation
errors, for test executables, it can lead to tests silently
not running.

BUG=chromium:474921

Committed: https://crrev.com/994dc21148e08da0e4986f1f4a118dd69d05a8b3
Cr-Commit-Position: refs/heads/master@{#37331}
==========

[commit-bot: I haz the power, 2016-06-28 13:24:20]

Patchset 7 (id:??) landed as
https://crrev.com/994dc21148e08da0e4986f1f4a118dd69d05a8b3
Cr-Commit-Position: refs/heads/master@{#37331}