Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 2098303003: X87: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. port 1b4e0130faee8115fae274f1d2c46cfa8ae5f415(r37181) original commit message: Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. BUG= Committed: https://crrev.com/7a02c7282f5b753efdeaa0bbbc90768a2b1ad89e Cr-Commit-Position: refs/heads/master@{#37320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/code-stubs-hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 09:54:20 UTC) #2
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-28 06:46:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098303003/1
4 years, 5 months ago (2016-06-28 08:51:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 09:12:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 09:14:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a02c7282f5b753efdeaa0bbbc90768a2b1ad89e
Cr-Commit-Position: refs/heads/master@{#37320}

Powered by Google App Engine
This is Rietveld 408576698