Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2098273002: [mojo-edk] Initialise padding in mojo::edk::BrokerMessageHeader. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Initialise padding in mojo::edk::BrokerMessageHeader. BUG=623413 NOPRESUBMIT=true Committed: https://crrev.com/e107d296d9c06165b36c8bc299b9025df094d49e Cr-Commit-Position: refs/heads/master@{#402114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/edk/system/broker_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Anand Mistry (off Chromium)
msan doesn't run locally for me, so this is a (reasoned) stab in the dark.
4 years, 5 months ago (2016-06-27 01:32:56 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-06-27 01:57:44 UTC) #3
Anand Mistry (off Chromium)
+dcheng since this technically needs a security reviewer or else the presubmit will complain.
4 years, 5 months ago (2016-06-27 02:22:19 UTC) #5
dcheng
rs lgtm
4 years, 5 months ago (2016-06-27 03:30:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098273002/1
4 years, 5 months ago (2016-06-27 04:09:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/207434)
4 years, 5 months ago (2016-06-27 04:14:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098273002/1
4 years, 5 months ago (2016-06-27 04:26:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 04:59:39 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 05:03:22 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e107d296d9c06165b36c8bc299b9025df094d49e
Cr-Commit-Position: refs/heads/master@{#402114}

Powered by Google App Engine
This is Rietveld 408576698