Update composited layer size if overflow from children requires it

Update composited layer size if overflow from children requires it

If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow
is the only thing that has changed we need to
watch for the need to expand the layer when
we compute overflow.

BUG=621612
Committed: https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25
Cr-Commit-Position: refs/heads/master@{#402242}

[rhogan, 2016-06-27 13:52:37]

robhogan@gmail.com changed reviewers:
+ wangxianzhu@chromium.org

[rhogan, 2016-06-27 13:52:37]

If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need
watch for the need to expand the layer when 
we computer overflow.

[rhogan, 2016-06-27 13:53:12]

Description was changed from

==========
Update composited layer size if overflow from children requires it

BUG=621612
==========

to

==========
Update composited layer size if overflow from children requires it
If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need
watch for the need to expand the layer when 
we computer overflow.

BUG=621612
==========

[rhogan, 2016-06-27 13:54:12]

Description was changed from

==========
Update composited layer size if overflow from children requires it
If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need
watch for the need to expand the layer when 
we computer overflow.

BUG=621612
==========

to

==========
Update composited layer size if overflow from children requires it
If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need to
watch for the need to expand the layer when 
we compute overflow.

BUG=621612
==========

[rhogan, 2016-06-27 13:54:28]

Description was changed from

==========
Update composited layer size if overflow from children requires it
If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need to
watch for the need to expand the layer when 
we compute overflow.

BUG=621612
==========

to

==========
Update composited layer size if overflow from children requires it

If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need to
watch for the need to expand the layer when 
we compute overflow.

BUG=621612
==========

[Xianzhu, 2016-06-27 16:49:35]

lgtm. Thanks!

(I thought we already had it. +cc trchen@.)

[Xianzhu, 2016-06-27 16:49:40]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-06-27 16:50:00]

The CQ bit was unchecked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:50:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-06-27 16:53:22]

https://codereview.chromium.org/2098223002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/repaint/overflow-changed-on-child-of-composited-layer.html
(right):

https://codereview.chromium.org/2098223002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/repaint/overflow-changed-on-child-of-composited-layer.html:12:
runRepaintTest();
Nit: onload = runRepaintAndPixelTest;

and add a reference for this test.

Now we support (and prefer) both pixel and text results for repaint tests
because text output only is easy for us to overlook some errors, and it doesn't
cover all rendering pipeline.

[rhogan, 2016-06-27 17:07:57]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-06-27 17:07:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2098223002/#ps60001
(title: "bug 621612")

[commit-bot: I haz the power, 2016-06-27 17:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:55:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-27 18:58:50]

Description was changed from

==========
Update composited layer size if overflow from children requires it

If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure 
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow 
is the only thing that has changed we need to
watch for the need to expand the layer when 
we compute overflow.

BUG=621612
==========

to

==========
Update composited layer size if overflow from children requires it

If a change to an element's overflow requires
the composited layer that paints it to
expand in size then we need to make sure
that expansion happens. Before, it was assured by
layout. Now that we skip layout if overflow
is the only thing that has changed we need to
watch for the need to expand the layer when
we compute overflow.

BUG=621612

Committed: https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25
Cr-Commit-Position: refs/heads/master@{#402242}
==========

[commit-bot: I haz the power, 2016-06-27 18:58:52]

Patchset 4 (id:??) landed as
https://crrev.com/3faa9d5121f4e933c111e8e3aca23f1fd5e3ba25
Cr-Commit-Position: refs/heads/master@{#402242}