appengine/cr-buildbucket/swarming/swarming.py - Issue 2098203002: swarmbucket: task TIMED_OUT is infra failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cr-buildbucket/swarming/swarming.py

Issue 2098203002: swarmbucket: task TIMED_OUT is infra failure (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cr-buildbucket/swarming/swarming.py

diff --git a/appengine/cr-buildbucket/swarming/swarming.py b/appengine/cr-buildbucket/swarming/swarming.py

index f94cced7dbbe1e8d5596078b84634416619720cf..bee0801730b5380971cd98c31782a304c442e918 100644

--- a/appengine/cr-buildbucket/swarming/swarming.py

+++ b/appengine/cr-buildbucket/swarming/swarming.py

@@ -411,9 +411,14 @@ def _update_build(build, result):

if state == 'CANCELED':

build.result = model.BuildResult.CANCELED

build.cancelation_reason = model.CancelationReason.CANCELED_EXPLICITLY

- elif state in ('TIMED_OUT', 'EXPIRED'):

+ elif state == 'EXPIRED':

Vadim Sh. 2016/06/28 18:05:35 this is also INFRA_FAILURE, it happens when we hav

nodir 2016/06/28 22:13:50 Done.

+ # Task did not start.

build.result = model.BuildResult.CANCELED

build.cancelation_reason = model.CancelationReason.TIMEOUT

+ elif state == 'TIMED_OUT':

+ # Task started, but timed out.

+ build.result = model.BuildResult.FAILURE

+ build.failure_reason = model.FailureReason.INFRA_FAILURE

elif state == 'BOT_DIED' or result.get('internal_failure'):

build.result = model.BuildResult.FAILURE

build.failure_reason = model.FailureReason.INFRA_FAILURE

« no previous file with comments | « no previous file | appengine/cr-buildbucket/swarming/test/swarming_test.py » ('j') | no next file with comments »