Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2098193002: Revert of [Media Router] Allow users to update cloud services pref when sync is not active. (Closed)

Created:
4 years, 6 months ago by apacible
Modified:
4 years, 6 months ago
Reviewers:
imcheng, Peter Kasting
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Allow users to update cloud services pref when sync is not active. (patchset #3 id:160001 of https://codereview.chromium.org/2078213002/ ) Reason for revert: Caused failure on official bots. Original issue's description: > [Media Router] Allow users to update cloud services pref when sync is not active. > > There are two places users can update their cloud services pref: > - First run flow, with a checkbox > - Contextual menu, with a toggle > > Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices. > > In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services. > > BUG=621255, 623330 > > Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17 > Cr-Commit-Position: refs/heads/master@{#402072} TBR=pkasting@chromium.org,imcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621255, 623330 Committed: https://crrev.com/03b18e91b52deceb82445a6739abeb595d781c15 Cr-Commit-Position: refs/heads/master@{#402073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -123 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu.cc View 2 chunks +11 lines, -4 lines 0 comments Download
D chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
apacible
Created Revert of [Media Router] Allow users to update cloud services pref when sync is ...
4 years, 6 months ago (2016-06-26 00:20:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098193002/1
4 years, 6 months ago (2016-06-26 00:20:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-26 00:22:03 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-26 00:24:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b18e91b52deceb82445a6739abeb595d781c15
Cr-Commit-Position: refs/heads/master@{#402073}

Powered by Google App Engine
This is Rietveld 408576698