Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2098173002: Add WebGL conformance expectations to Nexus 6P (Closed)

Created:
4 years, 6 months ago by cblume
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vmiura, ynovikov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebGL conformance expectations to Nexus 6P A handful of WebGL conformance tests were failing on the Nexus 6P. This adds them to the expectations file. BUG=611945 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e8a43ef07284631107ff31e6108b9872464e9512 Cr-Commit-Position: refs/heads/master@{#402296}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -6 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +158 lines, -6 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098173002/1
4 years, 6 months ago (2016-06-25 10:18:55 UTC) #3
cblume
This should bring the Nexus 6P back to green. PTAL
4 years, 6 months ago (2016-06-25 10:19:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-25 11:43:54 UTC) #7
cblume
https://codereview.chromium.org/2098173002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/2098173002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode409 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:409: ['android-content-shell', 'android-chromium', I added a comment above. But is ...
4 years, 5 months ago (2016-06-26 04:32:29 UTC) #8
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2098173002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/2098173002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode409 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:409: ['android-content-shell', 'android-chromium', On 2016/06/26 04:32:29, cblume wrote: > ...
4 years, 5 months ago (2016-06-27 20:17:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098173002/1
4 years, 5 months ago (2016-06-27 20:20:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 21:40:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:43:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8a43ef07284631107ff31e6108b9872464e9512
Cr-Commit-Position: refs/heads/master@{#402296}

Powered by Google App Engine
This is Rietveld 408576698