Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2098153002: Fix ODR violation in ppapi/proxy (Closed)

Created:
4 years, 6 months ago by piman
Modified:
4 years, 5 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ODR violation in ppapi/proxy ppapi/proxy component shouldn't be including gpu internal sources, but link against the gpu component. BUG=601189 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/864ffa6980cbf6a23a3f6a6153aa5a2ec93e2b3a Cr-Commit-Position: refs/heads/master@{#402276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M gpu/command_buffer/client/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
piman
4 years, 5 months ago (2016-06-27 19:06:38 UTC) #3
Fady Samuel
Ohh oops. Thanks for picking this up. Lgtn
4 years, 5 months ago (2016-06-27 19:12:13 UTC) #4
Fady Samuel
On 2016/06/27 19:12:13, Fady Samuel wrote: > Ohh oops. Thanks for picking this up. Lgtn ...
4 years, 5 months ago (2016-06-27 19:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098153002/1
4 years, 5 months ago (2016-06-27 19:39:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 21:01:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:03:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/864ffa6980cbf6a23a3f6a6153aa5a2ec93e2b3a
Cr-Commit-Position: refs/heads/master@{#402276}

Powered by Google App Engine
This is Rietveld 408576698