Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2098143002: Improve data sanitization of initialization data (Closed)

Created:
4 years, 6 months ago by jrummell
Modified:
4 years, 5 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve data sanitization of initialization data Data sanitization of the initialization data now verifies data is provided and for WebM, that the size is not larger than a single key ID. BUG=622840 TEST=EME tests pass checks for empty initData or WebM length Committed: https://crrev.com/16f875e5e84f9e1c084d5ca0eecb3ba606be8861 Cr-Commit-Position: refs/heads/master@{#403053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/blink/webcontentdecryptionmodulesession_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jrummell
PTAL.
4 years, 5 months ago (2016-06-27 17:14:16 UTC) #2
ddorwin
lgtm
4 years, 5 months ago (2016-06-27 17:23:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098143002/1
4 years, 5 months ago (2016-06-28 22:11:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/251894)
4 years, 5 months ago (2016-06-28 23:20:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098143002/1
4 years, 5 months ago (2016-06-29 20:52:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 01:19:13 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 01:19:24 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 01:22:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f875e5e84f9e1c084d5ca0eecb3ba606be8861
Cr-Commit-Position: refs/heads/master@{#403053}

Powered by Google App Engine
This is Rietveld 408576698