Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/resources/settings/languages_page/manage_languages_page.html

Issue 2098123002: [MD settings] checkbox ripple clipping with iron list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/manage_languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/manage_languages_page.html b/chrome/browser/resources/settings/languages_page/manage_languages_page.html
index 63ff5d9763bc5946a10d245d5e7b8f7b3925641f..8c0ecc822955b7d6c4af4d585787e43531d6d68c 100644
--- a/chrome/browser/resources/settings/languages_page/manage_languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/manage_languages_page.html
@@ -12,14 +12,20 @@
<template>
<style include="settings-shared">
.list-frame {
+ align-items: initial;
display: flex;
flex-direction: column;
- align-items: initial;
}
iron-list {
height: 300px;
}
+
+ .ripple-padding {
+ /* Create a little extra space for checkbox ink ripple to flow into. */
+ left: -20px;
tommycli 2016/06/25 00:31:34 Is iron-list already position: relative? I thought
dschuyler 2016/06/28 19:16:13 Yeah, it's here: https://cs.chromium.org/chromium
tommycli 2016/06/29 00:00:41 Maybe add a TODO to investigate a better option?
+ padding-left: 20px;
+ }
</style>
<settings-languages languages="{{languages}}"></settings-languages>
<div class="settings-box first block">
@@ -38,7 +44,7 @@
</div>
<h2>$i18n{allLanguages}</h2>
<div class="list-frame vertical-list">
- <iron-list items="{{languages.supported}}">
+ <iron-list class="ripple-padding" items="{{languages.supported}}">
<template>
<div class="list-item">
<paper-checkbox
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698