Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2098123002:
[MD settings] checkbox ripple clipping with iron list (Closed)
|
Created:
4 years, 5 months ago by dschuyler Modified:
4 years, 5 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] checkbox ripple clipping with iron list
This CL reduces the effect of iron-list clipping off the ink ripple
effect on paper-checkbox (e.g. in the language settings). The ripple can
still be clipped on the top and bottom. This CL fixes the more noticeable
clipping on the left edge.
BUG=608647
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/cca1a01d2fc00681e258522c6b9f8cb585636225
Cr-Commit-Position: refs/heads/master@{#402639}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 15 (6 generated)
Description was changed from ========== [MD settings] fix ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 ========== to ========== [MD settings] fix ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD settings] fix ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] checkbox ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/languages_page/manage_languages_page.html (right): https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/languages_page/manage_languages_page.html:26: left: -20px; Is iron-list already position: relative? I thought left property had no effect unless it was position relative, absolute, or fixed.
https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/languages_page/manage_languages_page.html (right): https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/languages_page/manage_languages_page.html:26: left: -20px; On 2016/06/25 00:31:34, tommycli wrote: > Is iron-list already position: relative? I thought left property had no effect > unless it was position relative, absolute, or fixed. Yeah, it's here: https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...
On 2016/06/28 19:16:13, dschuyler wrote: > https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/languages_page/manage_languages_page.html > (right): > > https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/languages_page/manage_languages_page.html:26: > left: -20px; > On 2016/06/25 00:31:34, tommycli wrote: > > Is iron-list already position: relative? I thought left property had no effect > > unless it was position relative, absolute, or fixed. > > Yeah, it's here: > > https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro... Arg... I can't think of a better solution, but this feels like an unclean solution. Is this the only iron-list that suffers from the ripple issue? Just wondering why the CSS rule is in manage_languages rather than settings_shared. Tommy
LGTM for now, after discussion, agreed to investigate a way to solve the ripple issue globally later. https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/languages_page/manage_languages_page.html (right): https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/languages_page/manage_languages_page.html:26: left: -20px; On 2016/06/28 19:16:13, dschuyler wrote: > On 2016/06/25 00:31:34, tommycli wrote: > > Is iron-list already position: relative? I thought left property had no effect > > unless it was position relative, absolute, or fixed. > > Yeah, it's here: > > https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro... Maybe add a TODO to investigate a better option?
On 2016/06/29 00:00:41, tommycli wrote: > LGTM for now, after discussion, agreed to investigate a way to solve the ripple > issue globally later. > > https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/languages_page/manage_languages_page.html > (right): > > https://codereview.chromium.org/2098123002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/languages_page/manage_languages_page.html:26: > left: -20px; > On 2016/06/28 19:16:13, dschuyler wrote: > > On 2016/06/25 00:31:34, tommycli wrote: > > > Is iron-list already position: relative? I thought left property had no > effect > > > unless it was position relative, absolute, or fixed. > > > > Yeah, it's here: > > > > > https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro... > > Maybe add a TODO to investigate a better option? After discussing it further, we came to UI needing general review. A bug for that is at https://bugs.chromium.org/p/chromium/issues/detail?id=624205
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD settings] checkbox ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] checkbox ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] checkbox ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] checkbox ripple clipping with iron list This CL reduces the effect of iron-list clipping off the ink ripple effect on paper-checkbox (e.g. in the language settings). The ripple can still be clipped on the top and bottom. This CL fixes the more noticeable clipping on the left edge. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cca1a01d2fc00681e258522c6b9f8cb585636225 Cr-Commit-Position: refs/heads/master@{#402639} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cca1a01d2fc00681e258522c6b9f8cb585636225 Cr-Commit-Position: refs/heads/master@{#402639} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
