Issue 2098083002: Bookmarks: revert ICU plural syntax for "Should we open all these bookmarks?" messsage

Issue 2098083002: Bookmarks: revert ICU plural syntax for "Should we open all these bookmarks?" messsage (Closed)

Created:
4 years, 6 months ago by Dan Beam

Modified:
4 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, jungshik at Google

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Bookmarks: revert ICU plural syntax for "Should we open all these bookmarks?" messsage Basically a partial revert of r397608 R=thestig@chromium.org BUG=619392 Committed: https://crrev.com/331ef7f54ea666407a123e92df2e39b97039bbb2 Cr-Commit-Position: refs/heads/master@{#402037}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	chrome/app/bookmarks_strings.grdp	View		1 chunk	+2 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 10 (4 generated)

Dan Beam

p.s. verified in the dev tools that the string was being translated correctly (even if ...

4 years, 6 months ago (2016-06-25 00:04:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098083002/1

4 years, 6 months ago (2016-06-25 00:04:44 UTC) #6

commit-bot: I haz the power

4 years, 6 months ago (2016-06-25 01:12:17 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/331ef7f54ea666407a123e92df2e39b97039bbb2
Cr-Commit-Position: refs/heads/master@{#402037}