Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer

Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer
Now that we have MediaTimelineConsumer, MediaConsumer should really be
MediaPacketConsumer and MediaProducer should really be
MediaPacketProducer. We're about to overhaul both packet interfaces, so
now is a good time to get this fixed. This CL also removes the pull
producer, which isn't used currently. It may come back in the future.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b6f8a91aa906fe5380cc86e1b9dafea52fb38d36

[dalesat, 2016-06-24 20:10:21]

Description was changed from

==========
Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer
Now that we have MediaTimelineConsumer, MediaConsumer should really be
MediaPacketConsumer and MediaProducer should really be
MediaPacketProducer. We're about to overhaul both packet interfaces, so
now is a good time to get this fixed. This CL also removes the pull
producer, which isn't used currently. It may come back in the future.
==========

to

==========
Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer
Now that we have MediaTimelineConsumer, MediaConsumer should really be
MediaPacketConsumer and MediaProducer should really be
MediaPacketProducer. We're about to overhaul both packet interfaces, so
now is a good time to get this fixed. This CL also removes the pull
producer, which isn't used currently. It may come back in the future.
==========

[dalesat, 2016-06-24 20:10:21]

dalesat@chromium.org changed reviewers:
+ kulakowski@chromium.org

[dalesat, 2016-06-24 20:10:33]

Please take a look. Thanks!

[kulakowski, 2016-06-27 16:57:13]

On 2016/06/24 20:10:33, dalesat wrote:
> Please take a look. Thanks!

Bot red but I doubt it's your fault?

BTW Is there any chance that in one place you accidentally changed producer to
consumer or vice versa?

[kulakowski, 2016-06-27 17:10:27]

https://codereview.chromium.org/2097953002/diff/20001/services/media/factory_...
File services/media/factory_service/media_decoder_impl.h (right):

https://codereview.chromium.org/2097953002/diff/20001/services/media/factory_...
services/media/factory_service/media_decoder_impl.h:5: #ifndef
MOJO_SERVICES_MEDIA_FACTORY_MEDIA_DECODER_IMPL_H_
Whereas e.g. here there is a leading MOJO which isn't present in the path to the
file name.

https://codereview.chromium.org/2097953002/diff/20001/services/media/framewor...
File services/media/framework_mojo/mojo_packet_producer.h (right):

https://codereview.chromium.org/2097953002/diff/20001/services/media/framewor...
services/media/framework_mojo/mojo_packet_producer.h:5: #ifndef
SERVICES_MEDIA_FRAMEWORK_MOJO_PACKET_PRODUCER_H_
Probably a nit: here and a few other places it seems like the naming of the
header include guards is slightly inconsistent. Here, for instance, there's only
one copy of the word MOJO which occurs twice in the full file name.

[dalesat, 2016-06-27 18:46:37]

Fixed all the #ifndef issues I could find. Remind me again why we can't use
#once?

https://codereview.chromium.org/2097953002/diff/20001/services/media/factory_...
File services/media/factory_service/media_decoder_impl.h (right):

https://codereview.chromium.org/2097953002/diff/20001/services/media/factory_...
services/media/factory_service/media_decoder_impl.h:5: #ifndef
MOJO_SERVICES_MEDIA_FACTORY_MEDIA_DECODER_IMPL_H_
On 2016/06/27 17:10:27, kulakowski wrote:
> Whereas e.g. here there is a leading MOJO which isn't present in the path to
the
> file name.

Done.

https://codereview.chromium.org/2097953002/diff/20001/services/media/framewor...
File services/media/framework_mojo/mojo_packet_producer.h (right):

https://codereview.chromium.org/2097953002/diff/20001/services/media/framewor...
services/media/framework_mojo/mojo_packet_producer.h:5: #ifndef
SERVICES_MEDIA_FRAMEWORK_MOJO_PACKET_PRODUCER_H_
On 2016/06/27 17:10:27, kulakowski wrote:
> Probably a nit: here and a few other places it seems like the naming of the
> header include guards is slightly inconsistent. Here, for instance, there's
only
> one copy of the word MOJO which occurs twice in the full file name.

Done.

[kulakowski, 2016-06-27 18:51:27]

lgtm

[kulakowski, 2016-06-27 18:52:08]

On 2016/06/27 18:51:27, kulakowski wrote:
> lgtm

Actually, I wonder why that bot was still red?

[dalesat, 2016-06-27 19:24:58]

Description was changed from

==========
Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer
Now that we have MediaTimelineConsumer, MediaConsumer should really be
MediaPacketConsumer and MediaProducer should really be
MediaPacketProducer. We're about to overhaul both packet interfaces, so
now is a good time to get this fixed. This CL also removes the pull
producer, which isn't used currently. It may come back in the future.
==========

to

==========
Motown: Rename MediaProducer/Consumer to MediaPacketProducer/Consumer
Now that we have MediaTimelineConsumer, MediaConsumer should really be
MediaPacketConsumer and MediaProducer should really be
MediaPacketProducer. We're about to overhaul both packet interfaces, so
now is a good time to get this fixed. This CL also removes the pull
producer, which isn't used currently. It may come back in the future.

R=kulakowski@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/b6f8a91aa906fe5380cc86e1b9d...
==========

[dalesat, 2016-06-27 19:24:59]

Committed patchset #3 (id:40001) manually as
b6f8a91aa906fe5380cc86e1b9dafea52fb38d36 (presubmit successful).