src/opts/SkBlitRow_opts_mips_dsp.cpp - Issue 2097883002: revise row blits to keep intermediate precision so that color is preserved when blended against its…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkBlitRow_opts_mips_dsp.cpp

Issue 2097883002: revise row blits to keep intermediate precision so that color is preserved when blended against its… (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: guard more changes with SK_SUPPORT_LEGACY_BROKEN_LERP Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/opts/SkBlitRow_opts_mips_dsp.cpp

diff --git a/src/opts/SkBlitRow_opts_mips_dsp.cpp b/src/opts/SkBlitRow_opts_mips_dsp.cpp

index e25f7c5f192aafeb426a8556a52e2ea3a81da532..42821919a35dab36178235f2d260dd0639bda05a 100644

--- a/src/opts/SkBlitRow_opts_mips_dsp.cpp

+++ b/src/opts/SkBlitRow_opts_mips_dsp.cpp

@@ -789,9 +789,15 @@ static void S32_Blend_BlitRow32_mips_dsp(SkPMColor* SK_RESTRICT dst,

"muleu_s.ph.qbr %[t5], %[t6], %[t5] \n\t"

"addiu %[src], %[src], 4 \n\t"

"addiu %[count], %[count], -1 \n\t"

+#ifdef SK_SUPPORT_LEGACY_BROKEN_LERP

"precrq.qb.ph %[t0], %[t3], %[t2] \n\t"

"precrq.qb.ph %[t2], %[t5], %[t4] \n\t"

"addu %[t1], %[t0], %[t2] \n\t"

+#else

+ "addu %[t0], %[t3], %[t5] \n\t"

+ "addu %[t2], %[t2], %[t4] \n\t"

+ "precrq.qb.ph %[t1], %[t0], %[t2] \n\t"

+#endif

"sw %[t1], 0(%[dst]) \n\t"

"b 1b \n\t"

" addi %[dst], %[dst], 4 \n\t"

« no previous file with comments | « src/opts/SkBlitRow_opts_arm_neon.cpp ('k') | src/opts/SkColor_opts_SSE2.h » ('j') | no next file with comments »