chrome/browser/resources/settings/device_page/display.js - Issue 2097763004: MD Settings: Display: Add snapping and collisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/display.js

Issue 2097763004: MD Settings: Display: Add snapping and collisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_547080_display_settings8a_drag

Patch Set: Rebase + More Feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/device_page/display_layout.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/device_page/display.js

diff --git a/chrome/browser/resources/settings/device_page/display.js b/chrome/browser/resources/settings/device_page/display.js

index 17af4583e5a47c35370cc7650de9cc3cb0bd5990..5b83b075579f10bada5cda397170860ad90c5332 100644

--- a/chrome/browser/resources/settings/device_page/display.js

+++ b/chrome/browser/resources/settings/device_page/display.js

@@ -233,17 +233,16 @@ Polymer({

/**

- * @param {!{detail: number}} e

+ * @param {!{detail: string}} e |e.detail| is the id of the selected display.

* @private

onSelectDisplay_: function(e) {

- var index = e.detail;

- assert(index >= 0);

- if (index >= this.displays.length)

- return;

- this.selectedDisplay = this.displays[e.detail];

- // Force active in case selected display was clicked.

- e.target.active = true;

+ var id = e.detail;

+ for (let display of this.displays) {

+ if (id != display.id)

+ continue;

+ this.selectedDisplay = display;

+ }

/** @private */