MD Settings: Display: Add snapping and collisions

chrome/browser/resources/settings/device_page/display.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-display' is the settings subpage for display settings.
  */
 
 cr.define('settings.display', function() {
@@ skipping 215 matching lines @@
     var widthStr = mode.width.toString();
     var heightStr = mode.height.toString();
     if (best)
       return this.i18n('displayResolutionTextBest', widthStr, heightStr);
     else if (mode.isNative)
       return this.i18n('displayResolutionTextNative', widthStr, heightStr);
     return this.i18n('displayResolutionText', widthStr, heightStr);
   },
 
   /**
-   * @param {!{detail: number}} e
+   * @param {!{detail: string}} e |e.detail| is the id of the selected display.
    * @private
    */
   onSelectDisplay_: function(e) {
-    var index = e.detail;
-    assert(index >= 0);
-    if (index >= this.displays.length)
-      return;
-    this.selectedDisplay = this.displays[e.detail];
-    // Force active in case selected display was clicked.
-    e.target.active = true;
+    var id = e.detail;
+    for (let display of this.displays) {
+      if (id != display.id)
+        continue;
+      this.selectedDisplay = display;
+    }
   },
 
   /** @private */
   onMakePrimaryTap_: function() {
     if (!this.selectedDisplay)
       return;
     if (this.selectedDisplay.id == this.primaryDisplayId)
       return;
     /** @type {!chrome.system.display.DisplayProperties} */ var properties = {
       isPrimary: true
@@ skipping 84 matching lines @@
   },
 
   /** @private */
   setPropertiesCallback_: function() {
     if (chrome.runtime.lastError) {
       console.error(
           'setDisplayProperties Error: ' + chrome.runtime.lastError.message);
     }
   },
 });