Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2097743002: Cleanup: decouple web_input_event_aura and ui_events_helper (Closed)

Created:
4 years, 6 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160502-MacViews-Elastic-FILE-MOVES
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: decouple web_input_event_aura and ui_events_helper MakeWebGestureEventFromUIEvent() is only called from web_input_event_aura.cc. Move it to an anonymous namespace so that web_input_event_aura.cc is easier to move to a component without having to drag ui_events_helper.h along with it. BUG=615948 Committed: https://crrev.com/16a0ce331a936f7c70425f4b53dedc14b840f43f Cr-Commit-Position: refs/heads/master@{#402094}

Patch Set 1 #

Patch Set 2 : zap #

Patch Set 3 : Zap patchset dependency #

Patch Set 4 : Whoops - that comment should be kept #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M content/browser/renderer_host/ui_events_helper.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 2 3 2 chunks +10 lines, -1 line 1 comment Download

Messages

Total messages: 12 (6 generated)
tapted
Hi sadrul, please take a look
4 years, 5 months ago (2016-06-24 11:57:39 UTC) #3
sadrul
lgtm
4 years, 5 months ago (2016-06-24 17:53:30 UTC) #4
tapted
https://codereview.chromium.org/2097743002/diff/60001/content/browser/renderer_host/web_input_event_aura.cc File content/browser/renderer_host/web_input_event_aura.cc (right): https://codereview.chromium.org/2097743002/diff/60001/content/browser/renderer_host/web_input_event_aura.cc#newcode56 content/browser/renderer_host/web_input_event_aura.cc:56: // the caller must populate these fields. (just noticed ...
4 years, 5 months ago (2016-06-27 00:18:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097743002/60001
4 years, 5 months ago (2016-06-27 00:18:54 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 01:19:57 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 01:24:23 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/16a0ce331a936f7c70425f4b53dedc14b840f43f
Cr-Commit-Position: refs/heads/master@{#402094}

Powered by Google App Engine
This is Rietveld 408576698