Specify billing address for autofill cards in PaymentRequest.

Specify billing address for autofill cards in PaymentRequest.

If a credit card has a billing address, then the billing address will
also be passed to the merchant. The billing address specification
redirects to the shipping address specification, so that's the format
used in this patch.

https://w3c.github.io/webpayments-methods-card/#billingaddress
https://w3c.github.io/browser-payment-api/#paymentaddress-interface

The credit card information is an "instrument detail" that's unique to
each payment method. Therefore, it's passed through mojo as a JSON
string.

A credit card payment instrument detail now might look like this:

{
  "cardholderName": "First Last",
  "cardNumber": "4111111111111111",
  "expiryMonth": "12",
  "expiryYear": "2020",
  "cardSecurityCode": "123",
  "billingAddress": {
    "country": "US",
    "region": "CA",
    "city": "Mountain View",
    "dependentLocality": "",
    "addressLine: [
      "1600 Amphitheatre Pkwy"
    ],
    "postalCode": "94043",
    "sortingCode": "",
    "languageCode": "en-US",
    "organization": "Google",
    "recipient": "First Last",
    "careOf": "",
    "phone": "(650) 253-0000"
  }
}

Additional changes in this patch:
 - Add billing addresses to several integration tests, because the plan
   is to require billing addresses until merchants have a way to specify
   that they are optional.
 - Remove total amounts from several integration tests, because total
   amounts are no longer passed to merchants in response.

BUG=602663
Committed: https://crrev.com/c498cd139a6791995261cd3ee3409a4caeb319f2
Cr-Commit-Position: refs/heads/master@{#401908}

[please use gerrit instead, 2016-06-24 01:24:46]

Description was changed from

==========
Specify billing address for autofill cards in PaymentRequest.

If a credit card has a billing address, then the billing address will
also be passed to the merchant. The billing address specification
redirects to the shipping address specification, so that's the format
used in this patch.

https://w3c.github.io/webpayments-methods-card/#billingaddress
https://w3c.github.io/browser-payment-api/#paymentaddress-interface

The credit card information is an "instrument detail" that's unique to
each payment method. Therefore, it's passed through mojo as a JSON
string.

Additional changes in this patch:
 - Add billing addresses to several integration tests, because the plan
   is to require billing addresses until merchants have a way to specify
   that they are optional.
 - Remove total amounts from several integration tests, because total
   amounts are no longer passed to merchants in response.

BUG=602663
==========

to

==========
Specify billing address for autofill cards in PaymentRequest.

If a credit card has a billing address, then the billing address will
also be passed to the merchant. The billing address specification
redirects to the shipping address specification, so that's the format
used in this patch.

https://w3c.github.io/webpayments-methods-card/#billingaddress
https://w3c.github.io/browser-payment-api/#paymentaddress-interface

The credit card information is an "instrument detail" that's unique to
each payment method. Therefore, it's passed through mojo as a JSON
string.

A credit card payment instrument detail now might look like this:

{
  "cardholderName": "First Last",
  "cardNumber": "4111111111111111",
  "expiryMonth": "12",
  "expiryYear": "2020",
  "cardSecurityCode": "123",
  "billingAddress": {
    "country": "US",
    "region": "CA",
    "city": "Mountain View",
    "dependentLocality": "",
    "addressLine: [
      "1600 Amphitheatre Pkwy"
    ],
    "postalCode": "94043",
    "sortingCode": "",
    "languageCode": "en-US",
    "organization": "Google",
    "recipient": "First Last",
    "careOf": "",
    "phone": "(650) 253-0000"
  }
}

Additional changes in this patch:
 - Add billing addresses to several integration tests, because the plan
   is to require billing addresses until merchants have a way to specify
   that they are optional.
 - Remove total amounts from several integration tests, because total
   amounts are no longer passed to merchants in response.

BUG=602663
==========

[please use gerrit instead, 2016-06-24 02:33:13]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-06-24 02:36:20]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-06-24 02:36:21]

dfalcantara@, ptal

[gone, 2016-06-24 15:25:21]

lgtm

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:94:

remove newline between } and json.endArray() to make it clear that that block is
creating the addressLine array

add newline between json.endArray() and json.name("postalCode")

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
(right):

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java:37:
billingAddressId));
Oddly satisfying to see "" get filled in.

[please use gerrit instead, 2016-06-24 16:56:19]

Sending to cq.

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:94:

On 2016/06/24 15:25:21, dfalcantara wrote:
> remove newline between } and json.endArray() to make it clear that that block
is
> creating the addressLine array
> 
> add newline between json.endArray() and json.name("postalCode")

Done.

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
(right):

https://codereview.chromium.org/2097713002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java:37:
billingAddressId));
On 2016/06/24 15:25:21, dfalcantara wrote:
> Oddly satisfying to see "" get filled in.

Acknowledged.

[please use gerrit instead, 2016-06-24 16:56:29]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-24 16:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2097713002/#ps30001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-24 16:57:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 18:06:23]

Committed patchset #2 (id:30001)

[commit-bot: I haz the power, 2016-06-24 18:08:55]

Description was changed from

==========
Specify billing address for autofill cards in PaymentRequest.

If a credit card has a billing address, then the billing address will
also be passed to the merchant. The billing address specification
redirects to the shipping address specification, so that's the format
used in this patch.

https://w3c.github.io/webpayments-methods-card/#billingaddress
https://w3c.github.io/browser-payment-api/#paymentaddress-interface

The credit card information is an "instrument detail" that's unique to
each payment method. Therefore, it's passed through mojo as a JSON
string.

A credit card payment instrument detail now might look like this:

{
  "cardholderName": "First Last",
  "cardNumber": "4111111111111111",
  "expiryMonth": "12",
  "expiryYear": "2020",
  "cardSecurityCode": "123",
  "billingAddress": {
    "country": "US",
    "region": "CA",
    "city": "Mountain View",
    "dependentLocality": "",
    "addressLine: [
      "1600 Amphitheatre Pkwy"
    ],
    "postalCode": "94043",
    "sortingCode": "",
    "languageCode": "en-US",
    "organization": "Google",
    "recipient": "First Last",
    "careOf": "",
    "phone": "(650) 253-0000"
  }
}

Additional changes in this patch:
 - Add billing addresses to several integration tests, because the plan
   is to require billing addresses until merchants have a way to specify
   that they are optional.
 - Remove total amounts from several integration tests, because total
   amounts are no longer passed to merchants in response.

BUG=602663
==========

to

==========
Specify billing address for autofill cards in PaymentRequest.

If a credit card has a billing address, then the billing address will
also be passed to the merchant. The billing address specification
redirects to the shipping address specification, so that's the format
used in this patch.

https://w3c.github.io/webpayments-methods-card/#billingaddress
https://w3c.github.io/browser-payment-api/#paymentaddress-interface

The credit card information is an "instrument detail" that's unique to
each payment method. Therefore, it's passed through mojo as a JSON
string.

A credit card payment instrument detail now might look like this:

{
  "cardholderName": "First Last",
  "cardNumber": "4111111111111111",
  "expiryMonth": "12",
  "expiryYear": "2020",
  "cardSecurityCode": "123",
  "billingAddress": {
    "country": "US",
    "region": "CA",
    "city": "Mountain View",
    "dependentLocality": "",
    "addressLine: [
      "1600 Amphitheatre Pkwy"
    ],
    "postalCode": "94043",
    "sortingCode": "",
    "languageCode": "en-US",
    "organization": "Google",
    "recipient": "First Last",
    "careOf": "",
    "phone": "(650) 253-0000"
  }
}

Additional changes in this patch:
 - Add billing addresses to several integration tests, because the plan
   is to require billing addresses until merchants have a way to specify
   that they are optional.
 - Remove total amounts from several integration tests, because total
   amounts are no longer passed to merchants in response.

BUG=602663

Committed: https://crrev.com/c498cd139a6791995261cd3ee3409a4caeb319f2
Cr-Commit-Position: refs/heads/master@{#401908}
==========

[commit-bot: I haz the power, 2016-06-24 18:08:56]

Patchset 2 (id:??) landed as
https://crrev.com/c498cd139a6791995261cd3ee3409a4caeb319f2
Cr-Commit-Position: refs/heads/master@{#401908}