Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2097663002: Refactor flexbox layout a bit (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor flexbox layout a bit Instead of passing around three different vectors with related data (children, child sizes, inflexible items), merge the two into a single vector that stores all the information. Bonus: We now reuse the flex base size instead of recalculating it. R=eae@chromium.org,dgrogan@chromium.org TEST=n/a, no change in behavior Committed: https://crrev.com/28af9c5b7b72c26531e01f65cc2d1451e4209e5d Cr-Commit-Position: refs/heads/master@{#402220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -73 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 13 chunks +66 lines, -66 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cbiesinger
4 years, 6 months ago (2016-06-23 20:23:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097663002/1
4 years, 6 months ago (2016-06-23 20:24:15 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 21:44:25 UTC) #5
eae
Nice! LGTM
4 years, 5 months ago (2016-06-27 16:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097663002/1
4 years, 5 months ago (2016-06-27 16:24:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 17:54:31 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:56:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28af9c5b7b72c26531e01f65cc2d1451e4209e5d
Cr-Commit-Position: refs/heads/master@{#402220}

Powered by Google App Engine
This is Rietveld 408576698