Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2097623003: Close the panel if show has been requested (Closed)

Created:
4 years, 6 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close the panel if show has been requested When a panel is requested to show, it may not be visible yet and isShowing will return false. If two panels try to show simultaneously this can cause the incorrect panel to appear. This change keeps track of whether peek has been called so there can be a corresponding close call, regardless of panel visibility. BUG=623017 Committed: https://crrev.com/967e335bb9ad405a0e13d7827d3cc1875d819914 Cr-Commit-Position: refs/heads/master@{#402218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mdjones
ptal
4 years, 6 months ago (2016-06-24 19:02:41 UTC) #2
Theresa
lgtm
4 years, 6 months ago (2016-06-24 23:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097623003/1
4 years, 5 months ago (2016-06-27 16:53:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 17:41:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/967e335bb9ad405a0e13d7827d3cc1875d819914 Cr-Commit-Position: refs/heads/master@{#402218}
4 years, 5 months ago (2016-06-27 17:44:05 UTC) #8
mdjones
4 years, 5 months ago (2016-06-28 20:57:40 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2108863003/ by mdjones@chromium.org.

The reason for reverting is: This patch does not entirely fix the issue since a
panel can be opened by the panel manager without being requested..

Powered by Google App Engine
This is Rietveld 408576698