Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2097583003: X87: [ia32] Propagate rmodes when computing MemoryOperands. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ia32] Propagate rmodes when computing MemoryOperands. port 8c1ba59aeeddba6e4d1684b0666315601d8326f3 (r36911) original commit message: RelocInfo modes were not propagated when computing MemoryOperands, on IA32. This needed to be fixed so that we can compile wasm code before creating instances, since the compiled code needs to be patched up for memory and globals references. This surfaces in asm-to-wasm scenarios. Added testing (rather, enhanced existing tests). Note patch#1 where we fail on ia32, and patch#2 with the fix. BUG= Committed: https://crrev.com/a88d41919a83bf70974263d522b98a1db3df9fff Cr-Commit-Position: refs/heads/master@{#37245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-24 09:13:57 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-24 09:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097583003/1
4 years, 6 months ago (2016-06-24 09:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 09:54:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 09:56:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a88d41919a83bf70974263d522b98a1db3df9fff
Cr-Commit-Position: refs/heads/master@{#37245}

Powered by Google App Engine
This is Rietveld 408576698