Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2097583002: Revert of Reland of: Refactor process_resources.py to use aapt's --extra-packages (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland of: Refactor process_resources.py to use aapt's --extra-packages (patchset #3 id:60001 of https://codereview.chromium.org/2096693002/ ) Reason for revert: Relanded the wrong patchset! Missing code for excluding styleable. Original issue's description: > Reland #2 Refactor process_resources.py to use aapt's --extra-packages > > Without --extra-packages, we now use the same code-path > to generate the current R.java as well as dependent R.java files. > Previously, we were combing aapt's R.java with our own template. > > Our custom template no longer generating assignments for non-array > styleable fields within onResourcesLoaded() (matches aapt's behaviour) > > Reason for reland: > Fixed GYP issue & verified all webrtc targets compile. > > TBR=jbudorick > BUG=none > > Committed: https://crrev.com/f3c8dfe0190ad701a9339436ff1d7f3b1e556e7d > Cr-Commit-Position: refs/heads/master@{#401624} TBR=jbudorick@chromium.org,phoglund@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/1459934bc93f7668b3b6b73d3fe4b739a909181c Cr-Commit-Position: refs/heads/master@{#401637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -102 lines) Patch
M build/android/gyp/process_resources.py View 8 chunks +82 lines, -102 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agrieve
Created Revert of Reland of: Refactor process_resources.py to use aapt's --extra-packages
4 years, 6 months ago (2016-06-23 17:18:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097583002/1
4 years, 6 months ago (2016-06-23 17:18:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 17:19:20 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:41:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1459934bc93f7668b3b6b73d3fe4b739a909181c
Cr-Commit-Position: refs/heads/master@{#401637}

Powered by Google App Engine
This is Rietveld 408576698