Split the mediastream module in Blink into mediastream and peerconnection

Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
Committed: https://crrev.com/17ca1449bfde88b279180bb85e52e5d4015d83f0
Cr-Commit-Position: refs/heads/master@{#402500}

[Guido Urdaneta, 2016-06-24 08:39:34]

Description was changed from

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
==========

to

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
==========

[Guido Urdaneta, 2016-06-24 08:39:35]

guidou@chromium.org changed reviewers:
+ mcasas@chromium.org

[Guido Urdaneta, 2016-06-24 11:38:54]

Hi, WDYT?
We probably have to adjust OWNERS files before landing this.

[Guido Urdaneta, 2016-06-24 11:39:20]

Patchset #2 (id:20001) has been deleted

[mcasas, 2016-06-24 17:23:46]

On 2016/06/24 11:38:54, Guido Urdaneta wrote:
> Hi, WDYT?
> We probably have to adjust OWNERS files before landing this.

Extracting RTC* out of the mediastream/ folder(s) and into their
own peerconnection/ folder(s) very much LGTM! Let's get 
Owners and ship it!

Curious: Did you use tools/git/mass-rename.py by any chance?

[Guido Urdaneta, 2016-06-24 18:23:34]

On 2016/06/24 17:23:46, mcasas wrote:
> On 2016/06/24 11:38:54, Guido Urdaneta wrote:
> > Hi, WDYT?
> > We probably have to adjust OWNERS files before landing this.
> 
> Extracting RTC* out of the mediastream/ folder(s) and into their
> own peerconnection/ folder(s) very much LGTM! Let's get 
> Owners and ship it!
> 
> Curious: Did you use tools/git/mass-rename.py by any chance?

No. Didn't know about it.
But it wasn't much work. git mv to move the files and manual adjusments to build
files and #includes

[Guido Urdaneta, 2016-06-27 10:07:16]

guidou@chromium.org changed reviewers:
+ hta@chromium.org, tommi@chromium.org

[Guido Urdaneta, 2016-06-27 10:09:48]

guidou@chromium.org changed reviewers:
+ haraken@chromium.org

[Guido Urdaneta, 2016-06-27 10:09:49]

Hi, PTAL

[tommi (sloooow) - chröme, 2016-06-27 10:44:32]

https://codereview.chromium.org/2097563002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/OWNERS (right):

https://codereview.chromium.org/2097563002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/OWNERS:3: peter@chromium.org
can you add yourself?

[Guido Urdaneta, 2016-06-27 11:59:14]

https://codereview.chromium.org/2097563002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/OWNERS (right):

https://codereview.chromium.org/2097563002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/OWNERS:3: peter@chromium.org
On 2016/06/27 10:44:32, tommi-chrömium wrote:
> can you add yourself?

Done. Removed peter@ to avoid overloading him with reviews.

[tommi (sloooow) - chröme, 2016-06-27 12:02:15]

lgtm

[mcasas, 2016-06-27 17:07:57]

https://codereview.chromium.org/2097563002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/OWNERS (right):

https://codereview.chromium.org/2097563002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/OWNERS:3: guidou@chromium.org
nit: Usually OWNERS follows an alphabetical order

[Guido Urdaneta, 2016-06-28 08:47:47]

guidou@chromium.org changed reviewers:
- haraken@chromium.org

[Guido Urdaneta, 2016-06-28 08:51:16]

guidou@chromium.org changed reviewers:
+ foolip@chromium.org

[Guido Urdaneta, 2016-06-28 08:53:04]

+foolip

https://codereview.chromium.org/2097563002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/peerconnection/OWNERS (right):

https://codereview.chromium.org/2097563002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/peerconnection/OWNERS:3: guidou@chromium.org
On 2016/06/27 17:07:56, mcasas wrote:
> nit: Usually OWNERS follows an alphabetical order

Done.

[hta - Chromium, 2016-06-28 09:52:50]

Basic idea seems sound, although I'm a bit worried about value-for-effort here.

Questions:

1) What do the bots say? I'm worried about whether we got all the #includes.
2) Is there a diff tool that will show the changes and ignore the moves? It
seems that codereview on the A+ files will do almost what I want, but is there a
way to ignore all the unchanged ones?

[Guido Urdaneta, 2016-06-28 10:00:38]

On 2016/06/28 09:52:50, hta - Chromium wrote:
> Basic idea seems sound, although I'm a bit worried about value-for-effort
here.
> 
> Questions:
> 
> 1) What do the bots say? I'm worried about whether we got all the #includes.

PS1 passed all bots. All further changes have been to the OWNERS file.

> 2) Is there a diff tool that will show the changes and ignore the moves? It
> seems that codereview on the A+ files will do almost what I want, but is there
a
> way to ignore all the unchanged ones?

git blame seems to be aware of file moves. At least, doing git blame locally
after the move shows the original authors for all lines.
There is also git hyper-blame, which allows ignoring specific commits.

[foolip, 2016-06-28 15:43:09]

lgtm

[Guido Urdaneta, 2016-06-28 15:44:41]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-06-28 15:44:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2097563002/#ps80001
(title: "OWNERS file in alphabetic order")

[commit-bot: I haz the power, 2016-06-28 15:45:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hta - Chromium, 2016-06-28 15:46:22]

lgtm

[Guido Urdaneta, 2016-06-28 15:48:40]

The CQ bit was unchecked by guidou@chromium.org

[Guido Urdaneta, 2016-06-28 15:57:42]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-06-28 15:57:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
tommi@chromium.org, hta@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2097563002/#ps100001
(title: "Add DEPS file")

[commit-bot: I haz the power, 2016-06-28 15:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 17:41:38]

Description was changed from

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
==========

to

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
==========

[commit-bot: I haz the power, 2016-06-28 17:41:40]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-06-28 17:43:11]

Description was changed from

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541
==========

to

==========
Split the mediastream module in Blink into mediastream and peerconnection

BUG=621541

Committed: https://crrev.com/17ca1449bfde88b279180bb85e52e5d4015d83f0
Cr-Commit-Position: refs/heads/master@{#402500}
==========

[commit-bot: I haz the power, 2016-06-28 17:43:13]

Patchset 5 (id:??) landed as
https://crrev.com/17ca1449bfde88b279180bb85e52e5d4015d83f0
Cr-Commit-Position: refs/heads/master@{#402500}