Add support for 3D colorLUTs to SkColorXform

Add support for 3D colorLUTs to SkColorXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097553002

Committed: https://skia.googlesource.com/skia/+/0f83e0151f757ecd8d55d55ffefef58ecb11a97b

[msarett, 2016-06-23 15:50:48]

Description was changed from

==========
Add support for 3D colorLUTs to SkColorXform

BUG=skia:
==========

to

==========
Add support for 3D colorLUTs to SkColorXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097553002
==========

[msarett, 2016-06-23 15:59:07]

Patchset #1 (id:1) has been deleted

[msarett, 2016-06-23 16:02:25]

msarett@google.com changed reviewers:
+ brianosman@google.com, mtklein@google.com, reed@google.com

[msarett, 2016-06-23 16:02:25]

This'll give us support for all four sections of that test image.

I'm not sure it fills in all of the gaps yet though.  I'll probably follow-up by
searching the web for more weird images.

[reed1, 2016-06-23 18:53:27]

lgtm

https://codereview.chromium.org/2097553002/diff/20001/src/core/SkColorSpaceXf...
File src/core/SkColorSpaceXform.h (right):

https://codereview.chromium.org/2097553002/diff/20001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.h:65: sk_sp<const SkColorLookUpTable> fColorLUT;
we ended up not using const instead the sk_sp<>, as that type is not the same as
sk_sp<Foo> even if the ptrs are the same. Do you need it here?

[msarett, 2016-06-23 19:46:49]

https://codereview.chromium.org/2097553002/diff/20001/src/core/SkColorSpaceXf...
File src/core/SkColorSpaceXform.h (right):

https://codereview.chromium.org/2097553002/diff/20001/src/core/SkColorSpaceXf...
src/core/SkColorSpaceXform.h:65: sk_sp<const SkColorLookUpTable> fColorLUT;
On 2016/06/23 18:53:27, reed1 wrote:
> we ended up not using const instead the sk_sp<>, as that type is not the same
as
> sk_sp<Foo> even if the ptrs are the same. Do you need it here?

I don't think I necessarily need it, but I'm not sure I complete understand your
comments.  It looks like this because of the signature of the getter on
SkColorSpace_Base.
const SkColorLUT* colorLUT() const;

I can make the getter just return SkColorLUT* (maybe a little strange because
the function itself is const) or I can const_cast or something...

Why don't we like sk_sp<const T>?  Is the preferred form just sk_sp<T>?

[msarett, 2016-06-23 21:47:10]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 21:47:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2097553002/40001

[commit-bot: I haz the power, 2016-06-23 21:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 21:48:46]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[msarett, 2016-06-23 21:50:49]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 21:50:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2097553002/60001

[commit-bot: I haz the power, 2016-06-23 22:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 22:09:06]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-06-23 22:11:44]

The CQ bit was checked by msarett@google.com

[msarett, 2016-06-23 22:11:45]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2097553002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-23 22:11:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2097553002/60001

[commit-bot: I haz the power, 2016-06-23 22:12:56]

Description was changed from

==========
Add support for 3D colorLUTs to SkColorXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097553002
==========

to

==========
Add support for 3D colorLUTs to SkColorXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097553002

Committed:
https://skia.googlesource.com/skia/+/0f83e0151f757ecd8d55d55ffefef58ecb11a97b
==========

[commit-bot: I haz the power, 2016-06-23 22:12:58]

Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/0f83e0151f757ecd8d55d55ffefef58ecb11a97b