Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2097533005: Set Chrome command buffer to be the default GPU command buffer (was mojo command buffer) (Closed)

Created:
4 years, 6 months ago by Alex Z.
Modified:
4 years, 5 months ago
Reviewers:
StarAZ, Peng, *sadrul, *sky
CC:
chromium-reviews, rjkroege, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set Chrome command buffer to be the default GPU command buffer (was mojo command buffer) BUG=621927 Committed: https://crrev.com/a27f9aa2fee82cdfb59539860ad4c635918cbc17 Cr-Commit-Position: refs/heads/master@{#402197}

Patch Set 1 #

Patch Set 2 : Kludge to use mojo command buffer #

Patch Set 3 : Added #else #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M components/mus/common/gpu_service.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M components/mus/common/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/common/switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/mus_app.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
StarAZ
sadrul@chromium.org: Please review changes in content/browser/renderer_host/render_process_host_impl.cc sky@chromium.org: Please review changes in components/mus/common/gpu_service.cc components/mus/common/switches.cc components/mus/common/switches.h components/mus/mus_app.cc ...
4 years, 6 months ago (2016-06-24 16:13:30 UTC) #3
sky
LGTM
4 years, 6 months ago (2016-06-24 16:27:41 UTC) #4
sadrul
lgtm
4 years, 6 months ago (2016-06-24 17:52:29 UTC) #5
Peng
On 2016/06/24 17:52:29, sadrul wrote: > lgtm lgtm
4 years, 6 months ago (2016-06-24 18:14:00 UTC) #6
StarAZ
I added a kludge to force using mojo command buffer if it is running on ...
4 years, 6 months ago (2016-06-24 19:51:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097533005/40001
4 years, 5 months ago (2016-06-27 15:30:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 16:30:16 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:31:34 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a27f9aa2fee82cdfb59539860ad4c635918cbc17
Cr-Commit-Position: refs/heads/master@{#402197}

Powered by Google App Engine
This is Rietveld 408576698