Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2097513002: Remove FPDFAPI_LoadCID2UnicodeMap. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Tom Sepez, weili
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FPDFAPI_LoadCID2UnicodeMap. This Cl removes FPDFAPI_LoadCID2UnicodeMap() and inlines the code into the one caller. Committed: https://pdfium.googlesource.com/pdfium/+/decfa7b0447538dec6cbcfa8ea50481f2173ce12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M core/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-23 13:26:47 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 15:17:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097513002/1
4 years, 6 months ago (2016-06-23 15:17:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 15:18:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/decfa7b0447538dec6cbcfa8ea50481f2173...

Powered by Google App Engine
This is Rietveld 408576698