Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2097493002: [tools/perf] Keep both browsers open for the whole of the dual browser test (Closed)

Created:
4 years, 6 months ago by perezju
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Keep both browsers open for the whole of the dual browser test Ensure that all browsers needed for the story set remain open for the whole duration of the test. This makes sure that, when taking memory dumps, we always get a dump for all browsers all the time. Previous attempt from https://codereview.chromium.org/2073713003/ did not work because the browsers need to be created *after* WPR has been started. BUG=616043 Committed: https://crrev.com/9a647d91e3999a0ba99963eefd6ce7460483116f Cr-Commit-Position: refs/heads/master@{#401598}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M tools/perf/page_sets/dual_browser_story.py View 4 chunks +32 lines, -20 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
perezju
4 years, 6 months ago (2016-06-23 10:51:28 UTC) #2
nednguyen
lgtm
4 years, 6 months ago (2016-06-23 13:10:40 UTC) #3
nednguyen
https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_browser_story.py File tools/perf/page_sets/dual_browser_story.py (right): https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_browser_story.py#newcode151 tools/perf/page_sets/dual_browser_story.py:151: if self._browsers_created: Are we calling _CreateAllBrowsersIfNeeeded twice anywhere? If ...
4 years, 6 months ago (2016-06-23 13:13:26 UTC) #4
nednguyen
https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_browser_story.py File tools/perf/page_sets/dual_browser_story.py (right): https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_browser_story.py#newcode151 tools/perf/page_sets/dual_browser_story.py:151: if self._browsers_created: On 2016/06/23 13:13:26, nednguyen wrote: > Are ...
4 years, 6 months ago (2016-06-23 13:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097493002/1
4 years, 6 months ago (2016-06-23 13:20:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 14:04:46 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:06:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a647d91e3999a0ba99963eefd6ce7460483116f
Cr-Commit-Position: refs/heads/master@{#401598}

Powered by Google App Engine
This is Rietveld 408576698