[tools/perf] Keep both browsers open for the whole of the dual browser test

[tools/perf] Keep both browsers open for the whole of the dual browser test

Ensure that all browsers needed for the story set remain open for the whole
duration of the test. This makes sure that, when taking memory dumps, we
always get a dump for all browsers all the time.

Previous attempt from https://codereview.chromium.org/2073713003/ did not
work because the browsers need to be created *after* WPR has been started.

BUG=616043
Committed: https://crrev.com/9a647d91e3999a0ba99963eefd6ce7460483116f
Cr-Commit-Position: refs/heads/master@{#401598}

[perezju, 2016-06-23 10:51:27]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com, primiano@chromium.org

[nednguyen, 2016-06-23 13:10:40]

lgtm

[nednguyen, 2016-06-23 13:13:26]

https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_b...
File tools/perf/page_sets/dual_browser_story.py (right):

https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_b...
tools/perf/page_sets/dual_browser_story.py:151: if self._browsers_created:
Are we calling _CreateAllBrowsersIfNeeeded twice anywhere? If not, maybe just
assert this is not called twice?

[nednguyen, 2016-06-23 13:14:06]

https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_b...
File tools/perf/page_sets/dual_browser_story.py (right):

https://codereview.chromium.org/2097493002/diff/1/tools/perf/page_sets/dual_b...
tools/perf/page_sets/dual_browser_story.py:151: if self._browsers_created:
On 2016/06/23 13:13:26, nednguyen wrote:
> Are we calling _CreateAllBrowsersIfNeeeded twice anywhere? If not, maybe just
> assert this is not called twice?

nvm, I forgot that WillRunStory is called in the loop

[perezju, 2016-06-23 13:20:44]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-06-23 13:20:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2097493002/1

[commit-bot: I haz the power, 2016-06-23 14:04:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-23 14:06:29]

Description was changed from

==========
[tools/perf] Keep both browsers open for the whole of the dual browser test

Ensure that all browsers needed for the story set remain open for the whole
duration of the test. This makes sure that, when taking memory dumps, we
always get a dump for all browsers all the time.

Previous attempt from https://codereview.chromium.org/2073713003/ did not
work because the browsers need to be created *after* WPR has been started.

BUG=616043
==========

to

==========
[tools/perf] Keep both browsers open for the whole of the dual browser test

Ensure that all browsers needed for the story set remain open for the whole
duration of the test. This makes sure that, when taking memory dumps, we
always get a dump for all browsers all the time.

Previous attempt from https://codereview.chromium.org/2073713003/ did not
work because the browsers need to be created *after* WPR has been started.

BUG=616043

Committed: https://crrev.com/9a647d91e3999a0ba99963eefd6ce7460483116f
Cr-Commit-Position: refs/heads/master@{#401598}
==========

[commit-bot: I haz the power, 2016-06-23 14:06:30]

Patchset 1 (id:??) landed as
https://crrev.com/9a647d91e3999a0ba99963eefd6ce7460483116f
Cr-Commit-Position: refs/heads/master@{#401598}