Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2097473002: [Interpreter] Add ValueOf intrinsic. (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add ValueOf intrinsic. BUG=v8:4822 Committed: https://crrev.com/13670e507391dc04b75b42b4adce18d3b0b5ff94 Cr-Commit-Position: refs/heads/master@{#37215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -36 lines) Patch
M src/interpreter/interpreter-intrinsics.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 3 chunks +48 lines, -35 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmcilroy
Mythri, please take a look, thanks.
4 years, 6 months ago (2016-06-23 09:58:19 UTC) #2
mythria
lgtm
4 years, 6 months ago (2016-06-23 10:49:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097473002/1
4 years, 6 months ago (2016-06-23 12:08:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 12:33:57 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 12:36:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13670e507391dc04b75b42b4adce18d3b0b5ff94
Cr-Commit-Position: refs/heads/master@{#37215}

Powered by Google App Engine
This is Rietveld 408576698