third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp - Issue 2097463002: Add backup element queue to CustomElementReactionStack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp

Issue 2097463002: Add backup element queue to CustomElementReactionStack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dominicc nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CEReactionsScope.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp b/third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp

index 817a91900e441d1eedb4811fce7e46ddebee5e99..dec7331dac87041e08f26ca8de954c0ea88d66d1 100644

--- a/third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp

@@ -13,15 +13,18 @@ namespace blink {

CEReactionsScope* CEReactionsScope::s_topOfStack = nullptr;

-void CEReactionsScope::enqueue(

+void CEReactionsScope::enqueueToCurrentQueue(

Element* element,

CustomElementReaction* reaction)

{

if (!m_frameHost.get()) {

m_frameHost = element->document().frameHost();

m_frameHost->customElementReactionStack().push();

+ } else {

+ DCHECK_EQ(m_frameHost, element->document().frameHost());

}

- m_frameHost->customElementReactionStack().enqueue(element, reaction);

+ m_frameHost->customElementReactionStack().enqueueToCurrentQueue(

+ element, reaction);

}

void CEReactionsScope::invokeReactions()