Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2097433002: gn: add Blink GC plugin options (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: add Blink GC plugin options The Blink GC clang plugin supports a couple of extra options which the Blink GN configuration does not currently expose. Do so here, but without depending on the 'flags' script used by the gyp build system (tools/clang/scripts/blink_gc_plugin_flags.py). Specifically, this adds the following Blink GN variables: - blink_gc_plugin_option_do_dump_graph [ = false ] emit JSON-serialized representation of class graph. - blink_gc_plugin_option_warn_unneeded_finalizer [ = false ] warn of unnecessary destructor usage. TBR=thakis BUG= Committed: https://crrev.com/a0ad50c5a8899f8c8a579758d2c586b68d48d44a Cr-Commit-Position: refs/heads/master@{#401568}

Patch Set 1 #

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M third_party/WebKit/Source/BUILD.gn View 2 chunks +43 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/config.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
please take a look. Part 2 of https://codereview.chromium.org/2081543002/. (https://codereview.chromium.org/2088373002/ appears to have landed ok..no trouble ...
4 years, 6 months ago (2016-06-23 09:07:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097433002/20001
4 years, 6 months ago (2016-06-23 09:07:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 09:47:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 09:49:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0ad50c5a8899f8c8a579758d2c586b68d48d44a
Cr-Commit-Position: refs/heads/master@{#401568}

Powered by Google App Engine
This is Rietveld 408576698