Issue 2097413002: Improve inlining of recognized methods in AOT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2097413002: Improve inlining of recognized methods in AOT. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve inlining of recognized methods in AOT. Also, assert that we don't repeatedly perform speculative inlining. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/22828c58cbcec26713dbc06a08cfcf79d8a2939d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -8 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Vyacheslav Egorov (Google)

LGTM Though we need to figure out better attempts system.

4 years, 5 months ago (2016-06-27 15:21:07 UTC) #3

Florian Schneider

4 years, 5 months ago (2016-06-27 15:55:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
22828c58cbcec26713dbc06a08cfcf79d8a2939d (presubmit successful).