Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(38)

Issue 2097393002: Pass origin clean flag of ImageBitmap when structure clone (Closed)

Created:
3 years, 3 months ago by xidachen
Modified:
3 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass origin clean flag of ImageBitmap when structure clone In this CL, we pass the origin clean flag of an ImageBitmap when this ImageBitmap is being structure cloned, so that the receive of the ImageBitmap is aware of this flag. BUG=623406 Committed: https://crrev.com/d790e336fd68029d802aa7da6d262eb5ef36488c Cr-Commit-Position: refs/heads/master@{#402204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
xidachen
PTAL
3 years, 3 months ago (2016-06-27 13:59:08 UTC) #2
haraken
LGTM
3 years, 3 months ago (2016-06-27 14:32:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097393002/1
3 years, 3 months ago (2016-06-27 14:33:13 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/245832)
3 years, 3 months ago (2016-06-27 14:43:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097393002/1
3 years, 3 months ago (2016-06-27 15:57:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 3 months ago (2016-06-27 17:03:25 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2016-06-27 17:05:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d790e336fd68029d802aa7da6d262eb5ef36488c
Cr-Commit-Position: refs/heads/master@{#402204}

Powered by Google App Engine
This is Rietveld 408576698