third_party/WebKit/Source/core/svg/SVGLengthContext.h - Issue 2097383002: Added support of calc() for SVGLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthContext.h

Issue 2097383002: Added support of calc() for SVGLength (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthContext.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthContext.h b/third_party/WebKit/Source/core/svg/SVGLengthContext.h

index 8cf071b1aadb5c0906fdd978255661af5db333fd..a47eefc0664f4dcb8ad79f4f79b5527ad72e4d11 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthContext.h

+++ b/third_party/WebKit/Source/core/svg/SVGLengthContext.h

@@ -77,6 +77,7 @@ public:

static float valueForLength(const Length&, const ComputedStyle&, float dimension);

bool determineViewport(FloatSize&) const;

+ float resolveValue(const CSSPrimitiveValue*, SVGLengthMode = SVGLengthMode::Other) const;

fs 2016/07/18 13:56:49 Nit: In think this should be const CSSPrimitiveVal

Shanmuga Pandi 2016/07/19 05:33:55 Done.

private:

float valueForLength(const Length&, float zoom, SVGLengthMode) const;