Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthList.cpp

Issue 2097383002: Added support of calc() for SVGLength (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGLengthList.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp
index e3137de6c0104ee8e642ccf11b1f73d6fcd78a30..b744166193448c94b8f6898f34e59720754f8ca3 100644
--- a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp
@@ -74,6 +74,7 @@ SVGParsingError SVGLengthList::parseInternal(const CharType*& ptr, const CharTyp
const CharType* listStart = ptr;
while (ptr < end) {
const CharType* start = ptr;
+ // TODO(shanmuga.m): Enable calc for SVGLengthList
while (ptr < end && *ptr != ',' && !isHTMLSpace<CharType>(*ptr))
ptr++;
if (ptr == start)
@@ -143,6 +144,7 @@ void SVGLengthList::calculateAnimatedValue(SVGAnimationElement* animationElement
return;
for (size_t i = 0; i < toLengthListSize; ++i) {
+ // TODO(shanmuga.m): Support calc for SVGLengthList animation
float animatedNumber = at(i)->value(lengthContext);
CSSPrimitiveValue::UnitType unitType = toList->at(i)->typeWithCalcResolved();
float effectiveFrom = 0;

Powered by Google App Engine
This is Rietveld 408576698