Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp

Issue 2097253002: Remove ExecutionContextTask subclasses from DOMFileSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ECT_TaskName
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp b/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
index 8143c8d2eec64d1e5ee12a7ff4b6774cb4090853..cda4d5750f4e8315f0f120dc1576ed4baaecfc7e 100644
--- a/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
@@ -100,18 +100,19 @@ void DirectoryReader::readEntries(EntriesCallback* entriesCallback, ErrorCallbac
}
if (m_error) {
- filesystem()->scheduleCallback(errorCallback, m_error);
+ filesystem()->reportError(errorCallback, m_error.get());
return;
}
if (m_entriesCallback) {
// Non-null m_entriesCallback means multiple readEntries() calls are made concurrently. We don't allow doing it.
- filesystem()->scheduleCallback(errorCallback, FileError::create(FileError::INVALID_STATE_ERR));
+ filesystem()->reportError(errorCallback, FileError::create(FileError::INVALID_STATE_ERR));
return;
}
if (!m_hasMoreEntries || !m_entries.isEmpty()) {
- filesystem()->scheduleCallback(entriesCallback, m_entries);
+ if (entriesCallback)
+ DOMFileSystem::scheduleCallback(filesystem()->getExecutionContext(), createSameThreadTask(&EntriesCallback::handleEvent, wrapPersistent(entriesCallback), PersistentHeapVector<Member<Entry>>(m_entries)));
m_entries.clear();
return;
}

Powered by Google App Engine
This is Rietveld 408576698