Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
209723002:
Fix dependencies for EventInterfaces.in (Closed)
|
Created:
6 years, 9 months ago by Nils Barth (inactive) Modified:
6 years, 9 months ago CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionFix dependencies for EventInterfaces.in
EventInterfaces.in should depend on event IDL files.
It currently doesn't, which means it fails to rebuild correctly.
This fixes it.
Previous approach (see discussion):
Add RuntimeEnabled info to InterfaceInfo.pickle.
https://codereview.chromium.org/208953004/
Alternative approach:
Move EventInterfaces.in generation to core/
https://codereview.chromium.org/212983010/
TBR=haraken
BUG=341748
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169998
Patch Set 1 #Patch Set 2 : Comment #Patch Set 3 : Fix circular dependency #
Messages
Total messages: 76 (0 generated)
Quick and correct fix to build issue.
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by nbarth@chromium.org
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
On 2014/03/25 08:45:12, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > tryserver.blink on mac_blink_compile_dbg This is a real failure; gyp is dying with: gyp: Cycles in .gyp file dependency graph detected: Cycle: third_party/WebKit/Source/core/core_generated.gyp -> third_party/WebKit/Source/bindings/generated_bindings.gyp -> third_party/WebKit/Source/core/core_generated.gyp This is not a cycle of *targets*, so it's not a real problem, but it does cause gyp to fail on some bots. This is fixed by not making the dependency in core_generated.gyp explicit. The better fix would be to refactor the target so it actually lives in core_generated.gyp, as this isn't actually part of generated bindings (and it barely uses the interfaces_info output anyway).
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by acolwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by nbarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/209723002/40001
Message was sent while issue was closed.
Change committed as 169998
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/212713002/ by vsevik@chromium.org. The reason for reverting is: This has broken android_aosp compilation. http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/5....
Message was sent while issue was closed.
On 2014/03/26 11:30:00, vsevik wrote: > A revert of this CL has been created in > https://codereview.chromium.org/212713002/ by mailto:vsevik@chromium.org. > > The reason for reverting is: This has broken android_aosp compilation. > > http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/5.... These two roll trials show that this was broken between 169977 and 170921. This patch looks like the culprit. https://codereview.chromium.org/211243008/ https://codereview.chromium.org/212153002/
Message was sent while issue was closed.
On 2014/03/26 11:32:33, vsevik wrote: > On 2014/03/26 11:30:00, vsevik wrote: > > A revert of this CL has been created in > > https://codereview.chromium.org/212713002/ by mailto:vsevik@chromium.org. > > > > The reason for reverting is: This has broken android_aosp compilation. > > > > > http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/5.... > > These two roll trials show that this was broken between 169977 and 170921. This > patch looks like the culprit. > https://codereview.chromium.org/211243008/ > https://codereview.chromium.org/212153002/ Yup, this CL was responsible. I've taken a different approach now: Move EventInterfaces.in generation to core/ https://codereview.chromium.org/212983010/ I'll check android_aosp before committing; any other things I should be aware of? |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
