Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 2097103002: Revert Mojo-based SyncChannel waiting again (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert Mojo-based SyncChannel waiting again Still seeing hangs, and not getting useful dumps from them. Note that this is a combined revert of both r401342 and r401090 since the former is dependent on the latter. BUG=612500, 622934, 622982 TBR=jam@chromium.org Committed: https://crrev.com/ee0123e23c43d56920e9ab0ab92cce3c6fb0a375 Cr-Commit-Position: refs/heads/master@{#401889}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -339 lines) Patch
M ipc/ipc_sync_channel.h View 7 chunks +16 lines, -25 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 19 chunks +97 lines, -147 lines 0 comments Download
M ipc/ipc_sync_message.h View 4 chunks +25 lines, -12 lines 0 comments Download
M ipc/ipc_sync_message.cc View 3 chunks +22 lines, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 4 chunks +3 lines, -24 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 7 chunks +12 lines, -130 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097103002/20001
4 years, 5 months ago (2016-06-24 16:24:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-06-24 17:27:53 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 17:29:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee0123e23c43d56920e9ab0ab92cce3c6fb0a375
Cr-Commit-Position: refs/heads/master@{#401889}

Powered by Google App Engine
This is Rietveld 408576698