Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: net/http/http_auth_cache.cc

Issue 2097043002: Clear HTTP auth data on clearing browsing data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clear auth data directly from BrowsingDataRemover Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_cache.cc
diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc
index 7a3a4e0f6714cb9b927af8d6c17fad4d0e8c12ae..0ff5e47cd4dc23ecb8fa6118d24d9ed065aef9c9 100644
--- a/net/http/http_auth_cache.cc
+++ b/net/http/http_auth_cache.cc
@@ -252,8 +252,24 @@ bool HttpAuthCache::Remove(const GURL& origin,
return false;
}
-void HttpAuthCache::Clear() {
- entries_.clear();
+void HttpAuthCache::Clear(base::Time delete_begin, base::Time delete_end) {
+ int64_t begin_millis =
+ delete_begin.is_null()
+ ? 0
+ : (delete_begin - base::Time::UnixEpoch()).InMilliseconds();
+ int64_t end_millis =
+ delete_end.is_null()
+ ? std::numeric_limits<int64_t>::max()
+ : (delete_end - base::Time::UnixEpoch()).InMilliseconds();
+
+ base::TimeTicks unix_epoch = base::TimeTicks::UnixEpoch();
+
+ entries_.remove_if(
+ [begin_millis, end_millis, unix_epoch](const Entry& entry) {
+ int64_t creation_millis =
+ (entry.creation_time_ - unix_epoch).InMilliseconds();
+ return creation_millis >= begin_millis && creation_millis < end_millis;
+ });
}
bool HttpAuthCache::UpdateStaleChallenge(const GURL& origin,
« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « net/http/http_auth_cache.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698