Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 2097043002: Clear HTTP auth data on clearing browsing data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index cc28d811f5cf714894cc6e8b8088d55c4368443b..c8426251fea00cd676812bf0933506d6ea6b2e1b 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -72,6 +72,8 @@
#include "content/public/browser/user_metrics.h"
#include "net/base/net_errors.h"
#include "net/cookies/cookie_store.h"
+#include "net/http/http_network_session.h"
+#include "net/http/http_transaction_factory.h"
#include "net/http/transport_security_state.h"
#include "net/ssl/channel_id_service.h"
#include "net/ssl/channel_id_store.h"
@@ -169,6 +171,20 @@ void ClearHostnameResolutionCacheOnIOThread(IOThread* io_thread) {
io_thread->ClearHostCache();
}
+void ClearHttpAuthCacheOnIOThread(
+ scoped_refptr<net::URLRequestContextGetter> context_getter,
+ base::Time delete_begin) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+ net::HttpNetworkSession* http_session = context_getter->GetURLRequestContext()
+ ->http_transaction_factory()
+ ->GetSession();
+ DCHECK(http_session);
+ http_session->http_auth_cache()->ClearEntriesAddedWithin(base::Time::Now() -
+ delete_begin);
+ http_session->CloseAllConnections();
+}
+
void ClearNetworkPredictorOnIOThread(chrome_browser_net::Predictor* predictor) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(predictor);
@@ -867,6 +883,18 @@ void BrowsingDataRemover::RemoveImpl(
weak_ptr_factory_.GetWeakPtr()));
}
+ if (remove_mask & REMOVE_COOKIES || remove_mask & REMOVE_PASSWORDS) {
+ scoped_refptr<net::URLRequestContextGetter> request_context =
+ profile_->GetRequestContext();
+ waiting_for_clear_http_auth_cache_ = true;
+ BrowserThread::PostTaskAndReply(
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&ClearHttpAuthCacheOnIOThread, std::move(request_context),
+ delete_begin_),
+ base::Bind(&BrowsingDataRemover::OnClearedHttpAuthCache,
+ weak_ptr_factory_.GetWeakPtr()));
+ }
+
// Content Decryption Modules used by Encrypted Media store licenses in a
// private filesystem. These are different than content licenses used by
// Flash (which are deleted father down in this method).
@@ -1077,6 +1105,7 @@ bool BrowsingDataRemover::AllDone() {
!waiting_for_clear_domain_reliability_monitor_ &&
!waiting_for_clear_form_ && !waiting_for_clear_history_ &&
!waiting_for_clear_hostname_resolution_cache_ &&
+ !waiting_for_clear_http_auth_cache_ &&
!waiting_for_clear_keyword_data_ && !waiting_for_clear_nacl_cache_ &&
!waiting_for_clear_network_predictor_ &&
!waiting_for_clear_networking_history_ &&
@@ -1142,6 +1171,12 @@ void BrowsingDataRemover::OnClearedHostnameResolutionCache() {
NotifyIfDone();
}
+void BrowsingDataRemover::OnClearedHttpAuthCache() {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ waiting_for_clear_http_auth_cache_ = false;
+ NotifyIfDone();
+}
+
void BrowsingDataRemover::OnClearedNetworkPredictor() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
waiting_for_clear_network_predictor_ = false;

Powered by Google App Engine
This is Rietveld 408576698