Clear HTTP auth data on clearing browsing data

net/http/http_auth_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_cache.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 
@@ skipping 234 matching lines @@
       if (credentials.Equals(it->credentials())) {
         entries_.erase(it);
         return true;
       }
       return false;
     }
   }
   return false;
 }
 
-void HttpAuthCache::Clear() {
-  entries_.clear();
+void HttpAuthCache::Clear(base::Time delete_begin, base::Time delete_end) {

[asanka, 2016/07/12 17:50:32]

How feasible would it be to have the API be: void Clear(base::TimeDelta
duration) where any auth cache entry created within |duration| of
base::TimeTicks::Now() would be removed? It seems such an API would be
comparable in accuracy to what's being done here and would also be independent
of whether times are store in TimeTicks or Time.

[Tomasz Moniuszko, 2016/07/15 11:41:34]

Done.

+  DCHECK(!delete_end.is_null());
+
+  time_t begin_time = delete_begin.ToTimeT();
+  time_t end_time = delete_end.ToTimeT();
+  base::TimeTicks unix_epoch = base::TimeTicks::UnixEpoch();
+
+  entries_.remove_if([begin_time, end_time, unix_epoch](const Entry& entry) {
+    int64_t creation_time = (entry.creation_time_ - unix_epoch).InSeconds();
+    return creation_time >= begin_time && creation_time < end_time;
+  });
 }
 
 bool HttpAuthCache::UpdateStaleChallenge(const GURL& origin,
                                          const std::string& realm,
                                          HttpAuth::Scheme scheme,
                                          const std::string& auth_challenge) {
   HttpAuthCache::Entry* entry = Lookup(origin, realm, scheme);
   if (!entry)
     return false;
   entry->UpdateStaleChallenge(auth_challenge);
@@ skipping 12 matching lines @@
     // Copy all other paths.
     for (Entry::PathList::const_reverse_iterator it2 = ++it->paths_.rbegin();
          it2 != it->paths_.rend(); ++it2)
       entry->AddPath(*it2);
     // Copy nonce count (for digest authentication).
     entry->nonce_count_ = it->nonce_count_;
   }
 }
 
 }  // namespace net