Clear HTTP auth data on clearing browsing data

chrome/browser/browsing_data/browsing_data_remover_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <list>
@@ skipping 60 matching lines @@
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/dom_storage_context.h"
 #include "content/public/browser/local_storage_usage_info.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "net/cookies/cookie_store.h"
+#include "net/http/http_network_session.h"
+#include "net/http/http_transaction_factory.h"
 #include "net/ssl/channel_id_service.h"
 #include "net/ssl/channel_id_store.h"
 #include "net/ssl/ssl_client_cert_type.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/favicon_size.h"
 #include "url/origin.h"
@@ skipping 43 matching lines @@
 const char kTestOrigin2[] = "http://host2.com:1/";
 const char kTestOrigin3[] = "http://host3.com:1/";
 const char kTestRegisterableDomain3[] = "host3.com";
 const char kTestOrigin4[] = "https://host3.com:1/";
 const char kTestOriginExt[] = "chrome-extension://abcdefghijklmnopqrstuvwxyz/";
 const char kTestOriginDevTools[] = "chrome-devtools://abcdefghijklmnopqrstuvw/";
 
 // For Autofill.
 const char kWebOrigin[] = "https://www.example.com/";
 
+// For HTTP auth.
+const char kTestRealm[] = "TestRealm";
+
 const GURL kOrigin1(kTestOrigin1);
 const GURL kOrigin2(kTestOrigin2);
 const GURL kOrigin3(kTestOrigin3);
 const GURL kOrigin4(kTestOrigin4);
 const GURL kOriginExt(kTestOriginExt);
 const GURL kOriginDevTools(kTestOriginDevTools);
 
 const base::FilePath::CharType kDomStorageOrigin1[] =
     FILE_PATH_LITERAL("http_host1_1.localstorage");
 
@@ skipping 683 matching lines @@
   // We don't own these pointers.
   TestingProfile* profile_;
   content::DOMStorageContext* dom_storage_context_ = nullptr;
 
   std::vector<content::LocalStorageUsageInfo> infos_;
   base::Closure quit_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(RemoveLocalStorageTester);
 };
 
+class ClearHttpAuthDataTester {

[mmenke, 2016/08/09 14:40:20]

Think this makes the tests needlessly obscure.  Looking at the test bodies, it's
not remotely clear that we check stat when this is torn down.  Think it's better
to either inline in the tests, or add two helper methods.

[Tomasz Moniuszko, 2016/08/25 10:32:59]

Done. I inlined the code.

+ public:
+  explicit ClearHttpAuthDataTester(TestingProfile* profile) {
+    net::HttpNetworkSession* http_session = profile->GetRequestContext()
+                                                ->GetURLRequestContext()
+                                                ->http_transaction_factory()
+                                                ->GetSession();
+    DCHECK(http_session);
+    http_auth_cache_ = http_session->http_auth_cache();
+
+    http_auth_cache_->Add(kOrigin1, kTestRealm,
+                          net::HttpAuth::AUTH_SCHEME_BASIC, "test challenge",
+                          net::AuthCredentials(base::ASCIIToUTF16("foo"),
+                                               base::ASCIIToUTF16("bar")),
+                          "/");
+    CHECK(http_auth_cache_->Lookup(kOrigin1, kTestRealm,
+                                   net::HttpAuth::AUTH_SCHEME_BASIC));
+  }
+
+  ~ClearHttpAuthDataTester() {
+    EXPECT_EQ(nullptr,
+              http_auth_cache_->Lookup(kOrigin1, kTestRealm,
+                                       net::HttpAuth::AUTH_SCHEME_BASIC));
+  }
+
+ private:
+  net::HttpAuthCache* http_auth_cache_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClearHttpAuthDataTester);
+};
+
 class MockDomainReliabilityService : public DomainReliabilityService {
  public:
   MockDomainReliabilityService() {}
 
   ~MockDomainReliabilityService() override {}
 
   std::unique_ptr<DomainReliabilityMonitor> CreateMonitor(
       scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
       override {
     NOTREACHED();
@@ skipping 1735 matching lines @@
       host_content_settings_map, CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT,
       base::Bind(&MatchPrimaryPattern, http_pattern));
   // Verify we only have one, and it's url1.
   host_content_settings_map->GetSettingsForOneType(
       CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(), &host_settings);
   EXPECT_EQ(1u, host_settings.size());
   EXPECT_EQ(ContentSettingsPattern::FromURLNoWildcard(url1),
             host_settings[0].primary_pattern);
 }
 
+// Test that removing cookies clears HTTP auth data.
+TEST_F(BrowsingDataRemoverTest, ClearHttpAuthCache_RemoveCookies) {
+  ClearHttpAuthDataTester tester(GetProfile());
+
+  BlockUntilBrowsingDataRemoved(browsing_data::ALL_TIME,
+                                BrowsingDataRemover::REMOVE_COOKIES, false);
+}
+
+// Test that removing passwords clears HTTP auth data.
+TEST_F(BrowsingDataRemoverTest, ClearHttpAuthCache_RemovePasswords) {
+  ClearHttpAuthDataTester tester(GetProfile());
+
+  BlockUntilBrowsingDataRemoved(browsing_data::ALL_TIME,
+                                BrowsingDataRemover::REMOVE_PASSWORDS, false);
+}
+
 class MultipleTasksObserver {
  public:
   // A simple implementation of BrowsingDataRemover::Observer.
   // MultipleTasksObserver will use several instances of Target to test
   // that completion callbacks are returned to the correct one.
   class Target : public BrowsingDataRemover::Observer {
    public:
     Target(MultipleTasksObserver* parent, BrowsingDataRemover* remover)
         : parent_(parent),
           observer_(this) {
@@ skipping 175 matching lines @@
   EXPECT_TRUE(remover->is_removing());
 
   // Add one more deletion and wait for it.
   BlockUntilBrowsingDataRemoved(
       browsing_data::ALL_TIME,
       BrowsingDataRemover::REMOVE_COOKIES,
       BrowsingDataHelper::UNPROTECTED_WEB);
 
   EXPECT_FALSE(remover->is_removing());
 }