Clear HTTP auth data on clearing browsing data

chrome/browser/browsing_data/browsing_data_remover_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 59 matching lines @@
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/dom_storage_context.h"
 #include "content/public/browser/local_storage_usage_info.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "net/cookies/cookie_store.h"
+#include "net/http/http_network_session.h"
+#include "net/http/http_transaction_factory.h"
 #include "net/ssl/channel_id_service.h"
 #include "net/ssl/channel_id_store.h"
 #include "net/ssl/ssl_client_cert_type.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/favicon_size.h"
 #include "url/origin.h"
@@ skipping 744 matching lines @@
   // We don't own these pointers.
   TestingProfile* profile_;
   content::DOMStorageContext* dom_storage_context_ = nullptr;
 
   std::vector<content::LocalStorageUsageInfo> infos_;
   base::Closure quit_closure_;
 
   DISALLOW_COPY_AND_ASSIGN(RemoveLocalStorageTester);
 };
 
+class ClearHTTPAuthDataTester {
+ public:
+  explicit ClearHTTPAuthDataTester(TestingProfile* profile) {
+    net::HttpNetworkSession* http_session = profile->GetRequestContext()
+                                                ->GetURLRequestContext()
+                                                ->http_transaction_factory()
+                                                ->GetSession();
+    DCHECK(http_session);
+    http_auth_cache_ = http_session->http_auth_cache();
+
+    http_auth_cache_->Add(
+        GURL("http://foo.com"), "Realm1", net::HttpAuth::AUTH_SCHEME_BASIC,
+        "basic realm=Realm1", net::AuthCredentials(base::ASCIIToUTF16("foo"),
+                                                   base::ASCIIToUTF16("bar")),
+        "/");
+  }
+
+  ~ClearHTTPAuthDataTester() {
+    GURL origin("http://foobar.com");
+    EXPECT_EQ(nullptr,
+              http_auth_cache_->Lookup(GURL("http://foo.com"), "Realm1",

[msramek, 2016/08/01 14:42:37]

Nit: Can you please add the same lookup to the constructor? We want to assure
that the lookup in this destructor fails because the entry was deleted and not
because adding it failed.

+                                       net::HttpAuth::AUTH_SCHEME_BASIC));
+  }
+
+ private:
+  net::HttpAuthCache* http_auth_cache_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClearHTTPAuthDataTester);
+};
+
 class MockDomainReliabilityService : public DomainReliabilityService {
  public:
   MockDomainReliabilityService() {}
 
   ~MockDomainReliabilityService() override {}
 
   std::unique_ptr<DomainReliabilityMonitor> CreateMonitor(
       scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
       override {
     NOTREACHED();
@@ skipping 1731 matching lines @@
   BrowsingDataRemover::ClearSettingsForOneTypeWithPredicate(
       host_content_settings_map, CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT,
       base::Bind(&MatchPrimaryPattern, http_pattern));
   // Verify we only have one, and it's url1.
   host_content_settings_map->GetSettingsForOneType(
       CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(), &host_settings);
   EXPECT_EQ(1u, host_settings.size());
   EXPECT_EQ(ContentSettingsPattern::FromURLNoWildcard(url1),
             host_settings[0].primary_pattern);
 }
+
+// Test that removing cookies clears HTTP auth data.
+TEST_F(BrowsingDataRemoverTest, ClearHttpAuthCache_RemoveCookies) {
+  ClearHTTPAuthDataTester tester(GetProfile());
+
+  BlockUntilBrowsingDataRemoved(browsing_data::ALL_TIME,
+                                BrowsingDataRemover::REMOVE_COOKIES, false);
+}
+
+// Test that removing passwords clears HTTP auth data.
+TEST_F(BrowsingDataRemoverTest, ClearHttpAuthCache_RemovePasswords) {
+  ClearHTTPAuthDataTester tester(GetProfile());
+
+  BlockUntilBrowsingDataRemoved(browsing_data::ALL_TIME,
+                                BrowsingDataRemover::REMOVE_PASSWORDS, false);
+}