MacViews: Fix failing mouse capture unittests.

MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403
Committed: https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518
Cr-Commit-Position: refs/heads/master@{#402388}

[karandeepb, 2016-06-24 05:27:09]

Patchset #2 (id:20001) has been deleted

[karandeepb, 2016-06-24 05:27:17]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-06-24 05:33:30]

Description was changed from

==========
Mouse capture unittests.
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=607403
==========

[karandeepb, 2016-06-24 05:47:21]

Description was changed from

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=607403
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=607403
==========

[karandeepb, 2016-06-24 06:05:55]

Description was changed from

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=607403
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979
==========

[karandeepb, 2016-06-24 06:07:18]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-06-24 06:07:19]

PTAL Trent. Thanks.

https://codereview.chromium.org/2096993002/diff/40001/ui/views/widget/native_...
File ui/views/widget/native_widget_mac.mm (right):

https://codereview.chromium.org/2096993002/diff/40001/ui/views/widget/native_...
ui/views/widget/native_widget_mac.mm:728: gfx::NativeView native_view) {
It seems strange that this accepts a |native_view| parameter. Isn't it the case
that only one aura window can have capture at a time. Then there should be no
reason for this to accept a |native_view| parameter. 

Looks like this is needed because CaptureClient can't have a static
GetGlobalCaptureWindow method.

[tapted, 2016-06-24 07:19:11]

nice! lgtm

https://codereview.chromium.org/2096993002/diff/60001/ui/views/cocoa/cocoa_mo...
File ui/views/cocoa/cocoa_mouse_capture_unittest.mm (right):

https://codereview.chromium.org/2096993002/diff/60001/ui/views/cocoa/cocoa_mo...
ui/views/cocoa/cocoa_mouse_capture_unittest.mm:39: TestCaptureDelegate(NSWindow*
window)
nit: explicit

[karandeepb, 2016-06-24 09:32:34]

https://codereview.chromium.org/2096993002/diff/60001/ui/views/cocoa/cocoa_mo...
File ui/views/cocoa/cocoa_mouse_capture_unittest.mm (right):

https://codereview.chromium.org/2096993002/diff/60001/ui/views/cocoa/cocoa_mo...
ui/views/cocoa/cocoa_mouse_capture_unittest.mm:39: TestCaptureDelegate(NSWindow*
window)
On 2016/06/24 07:19:11, tapted wrote:
> nit: explicit

Done.

[karandeepb, 2016-06-24 09:33:26]

karandeepb@chromium.org changed reviewers:
+ sky@chromium.org

[karandeepb, 2016-06-24 09:33:26]

+sky for ui/views/test/event_generator_delegate_mac.mm owners review.

[sky, 2016-06-24 16:02:12]

LGTM - tapted should really be an owner of all the mac files in views. Please
update OWNERS files as necessary.

[karandeepb, 2016-06-28 03:02:44]

Description was changed from

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403
==========

[karandeepb, 2016-06-28 03:02:56]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-06-28 03:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2096993002/#ps120001
(title: "Enable tests.")

[commit-bot: I haz the power, 2016-06-28 03:03:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 03:38:11]

Description was changed from

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403
==========

[commit-bot: I haz the power, 2016-06-28 03:38:13]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-06-28 03:41:17]

Description was changed from

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:   
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403
==========

to

==========
MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG=622979, 607403

Committed: https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518
Cr-Commit-Position: refs/heads/master@{#402388}
==========

[commit-bot: I haz the power, 2016-06-28 03:41:19]

Patchset 5 (id:??) landed as
https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518
Cr-Commit-Position: refs/heads/master@{#402388}