Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2096983002: clean oobe mono audio setting as they are not used (Closed)

Created:
4 years, 6 months ago by Qiang(Joe) Xu
Modified:
4 years, 6 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean oobe mono audio setting as they are not used BUG=622959 TEST=none Committed: https://crrev.com/2ea32a019d497090bbf536ecbbc7cff779a2ccdf Cr-Commit-Position: refs/heads/master@{#401823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096983002/1
4 years, 6 months ago (2016-06-24 03:01:56 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 04:18:33 UTC) #4
Qiang(Joe) Xu
alex, could you help review on this? tks It is added in my original CL ...
4 years, 6 months ago (2016-06-24 04:21:38 UTC) #7
Alexander Alekseev
lgtm with nit: Please add "TEST=none" line to your CL description.
4 years, 6 months ago (2016-06-24 05:43:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096983002/1
4 years, 6 months ago (2016-06-24 05:46:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 05:50:41 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 05:52:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ea32a019d497090bbf536ecbbc7cff779a2ccdf
Cr-Commit-Position: refs/heads/master@{#401823}

Powered by Google App Engine
This is Rietveld 408576698