[ios] Do not show SSL interstitial if cert is absent or cannot be parsed

[ios] Do not show SSL interstitial if cert is absent or cannot be parsed

This fixes a crash in SSL Interstitial code which expects that cert
exists. Error page with ERR_SSL_SERVER_CERT_BAD_FORMAT error code is
used in this case which matches other platforms.

BUG=622450
Committed: https://crrev.com/52c43f4c9f148d760553d8d6b1e883487e06d7b9
Cr-Commit-Position: refs/heads/master@{#403356}

[Eugene But (OOO till 7-30), 2016-06-24 02:38:36]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2016-06-24 02:38:37]

If you happy with the general approach I will write a few unit tests for error
translation.

[kkhorimoto, 2016-06-28 17:12:31]

Approach looks good; will lgtm with added tests.

[kkhorimoto, 2016-06-28 17:12:46]

On 2016/06/28 17:12:31, kkhorimoto_ wrote:
> Approach looks good; will lgtm with added tests.

not lgtm until tests are added.

[Eugene But (OOO till 7-30), 2016-06-28 22:01:45]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 22:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:22:01]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-06-29 03:39:21]

Wrote tests for error_translation_util. Error presentation for web controller is
not really testable (like most of WC stuff).

[Eugene But (OOO till 7-30), 2016-06-30 18:03:57]

Kurt? PTAL

[kkhorimoto, 2016-06-30 22:33:21]

lgtm

[Eugene But (OOO till 7-30), 2016-06-30 22:57:05]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-06-30 22:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:58:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 23:58:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 00:00:56]

Description was changed from

==========
[ios] Do not show SSL interstitial if cert is absent or cannot be parsed

This fixes a crash in SSL Interstitial code which expects that cert
exists. Error page with ERR_SSL_SERVER_CERT_BAD_FORMAT error code is
used in this case which matches other platforms.

BUG=622450
==========

to

==========
[ios] Do not show SSL interstitial if cert is absent or cannot be parsed

This fixes a crash in SSL Interstitial code which expects that cert
exists. Error page with ERR_SSL_SERVER_CERT_BAD_FORMAT error code is
used in this case which matches other platforms.

BUG=622450

Committed: https://crrev.com/52c43f4c9f148d760553d8d6b1e883487e06d7b9
Cr-Commit-Position: refs/heads/master@{#403356}
==========

[commit-bot: I haz the power, 2016-07-01 00:00:57]

Patchset 2 (id:??) landed as
https://crrev.com/52c43f4c9f148d760553d8d6b1e883487e06d7b9
Cr-Commit-Position: refs/heads/master@{#403356}