Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2096943004: [css-flexbox] Correctly implement freezing of inflexible items (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Correctly implement freezing of inflexible items We did not have a correct implementation of steps 2 and 3 of the "9.7 Resolving flexible lengths" section of the spec: https://drafts.csswg.org/css-flexbox/#resolve-flexible-lengths In particular inflexible items (flex factor 0 or flex basis violating the min/max size constraint) reduce the initial free space. This is an issue when sizing flex items with a flex factor of 0..1. BUG=617956 TEST=css3/flexbox/max-width-violation.html Committed: https://crrev.com/143408653a5c0328254ea06d0f3a825d6505a114 Cr-Commit-Position: refs/heads/master@{#402279}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : rebased #

Patch Set 4 : fix bad merge #

Patch Set 5 : .. #

Patch Set 6 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/max-width-violation.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 3 4 5 3 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/1
4 years, 5 months ago (2016-06-24 22:07:56 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/158493)
4 years, 5 months ago (2016-06-24 22:19:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/20001
4 years, 5 months ago (2016-06-24 22:22:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/40001
4 years, 5 months ago (2016-06-27 18:33:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/60001
4 years, 5 months ago (2016-06-27 18:41:12 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/80001
4 years, 5 months ago (2016-06-27 18:42:53 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/87686)
4 years, 5 months ago (2016-06-27 18:55:50 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/100001
4 years, 5 months ago (2016-06-27 19:32:56 UTC) #17
cbiesinger
4 years, 5 months ago (2016-06-27 19:48:43 UTC) #19
cbiesinger
Note, this patch also renames availableFreeSpace to initialFreeSpace to be clearer and to match the ...
4 years, 5 months ago (2016-06-27 19:49:49 UTC) #20
eae
LGTM
4 years, 5 months ago (2016-06-27 20:51:51 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096943004/100001
4 years, 5 months ago (2016-06-27 20:55:18 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-27 21:07:13 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:09:36 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/143408653a5c0328254ea06d0f3a825d6505a114
Cr-Commit-Position: refs/heads/master@{#402279}

Powered by Google App Engine
This is Rietveld 408576698