Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 2096933002: Remove all harmony runtime flags which shipped in M51 (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove all harmony runtime flags which shipped in M51 Flags removed (all begin with "harmony-"): function-name instanceof iterator-close unicode-regexps regexp-exec regexp-subclass species BUG=v8:3566, v8:3648, v8:3699, v8:4093, v8:4447, v8:4602 Committed: https://crrev.com/c7eb436d09d5fa10ef41a3312edea2d7a2680126 Cr-Commit-Position: refs/heads/master@{#37235}

Patch Set 1 #

Patch Set 2 : Move one more test #

Total comments: 4

Patch Set 3 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -3857 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +0 lines, -36 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/js/array.js View 5 chunks +10 lines, -13 lines 0 comments Download
M src/js/arraybuffer.js View 2 chunks +8 lines, -0 lines 0 comments Download
M src/js/collection.js View 5 chunks +16 lines, -0 lines 0 comments Download
D src/js/harmony-regexp-exec.js View 1 chunk +0 lines, -37 lines 0 comments Download
D src/js/harmony-species.js View 1 chunk +0 lines, -60 lines 0 comments Download
D src/js/harmony-unicode-regexps.js View 1 chunk +0 lines, -40 lines 0 comments Download
M src/js/promise.js View 3 chunks +8 lines, -0 lines 0 comments Download
M src/js/regexp.js View 1 2 7 chunks +31 lines, -41 lines 0 comments Download
M src/js/runtime.js View 1 2 3 chunks +15 lines, -33 lines 0 comments Download
M src/js/symbol.js View 2 chunks +10 lines, -5 lines 0 comments Download
M src/js/typedarray.js View 3 chunks +6 lines, -0 lines 0 comments Download
M src/lookup.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/messages.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/objects.cc View 3 chunks +19 lines, -25 lines 0 comments Download
M src/parsing/parser.cc View 6 chunks +2 lines, -11 lines 0 comments Download
M src/parsing/parser-base.h View 7 chunks +4 lines, -13 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M src/parsing/scanner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/fuzzer/regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/message/instanceof-noncallable.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/instanceof-nonobject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/optimized-instanceof-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/optimized-instanceof-2.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/array-species-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-constructor-accessor.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-constructor-delete.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-delete.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-modified.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-parent-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/array-species-proto.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/arraybuffer-species.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/es6/debug-step-into-regexp-subclass.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/function-name.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/instanceof.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/iterator-close.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/es6/legacy-subclassing.js View 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/es6/no-unicode-regexp-flag.js View 1 chunk +0 lines, -24 lines 0 comments Download
M test/mjsunit/es6/pattern-brand-check.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/promise-species.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-constructor.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/species.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-match.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-replace.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/string-search.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-split.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/typedarray-species.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-character-ranges.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/unicode-escapes-in-regexps.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-regexp-backrefs.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/unicode-regexp-ignore-case.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-regexp-ignore-case-noi18n.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-regexp-last-index.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/unicode-regexp-restricted-syntax.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-regexp-unanchored-advance.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/unicode-regexp-zero-length.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/array-species.js View 1 chunk +0 lines, -173 lines 0 comments Download
D test/mjsunit/harmony/array-species-constructor.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/harmony/array-species-constructor-accessor.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/harmony/array-species-constructor-delete.js View 1 chunk +0 lines, -29 lines 0 comments Download
D test/mjsunit/harmony/array-species-delete.js View 1 chunk +0 lines, -29 lines 0 comments Download
D test/mjsunit/harmony/array-species-modified.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/harmony/array-species-parent-constructor.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/harmony/array-species-proto.js View 1 chunk +0 lines, -28 lines 0 comments Download
D test/mjsunit/harmony/arraybuffer-species.js View 1 chunk +0 lines, -36 lines 0 comments Download
M test/mjsunit/harmony/function-name.js View 1 1 chunk +0 lines, -372 lines 0 comments Download
D test/mjsunit/harmony/instanceof-es6.js View 1 chunk +0 lines, -69 lines 0 comments Download
D test/mjsunit/harmony/iterator-close.js View 1 chunk +0 lines, -1372 lines 0 comments Download
D test/mjsunit/harmony/promise-species.js View 1 chunk +0 lines, -42 lines 0 comments Download
M test/mjsunit/harmony/regexp-change-exec.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/regexp-no-change-exec.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-binary.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-blocks.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-char-class.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-disabled.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-enumerated.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-exact-match.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-general-category.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-lu-ui.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-scripts.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-property-special.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/species.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/mjsunit/harmony/string-match.js View 1 chunk +0 lines, -20 lines 0 comments Download
D test/mjsunit/harmony/string-replace.js View 1 chunk +0 lines, -19 lines 0 comments Download
D test/mjsunit/harmony/string-split.js View 1 chunk +0 lines, -21 lines 0 comments Download
D test/mjsunit/harmony/typedarray-species.js View 1 chunk +0 lines, -86 lines 0 comments Download
D test/mjsunit/harmony/unicode-character-ranges.js View 1 chunk +0 lines, -158 lines 0 comments Download
D test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 chunk +0 lines, -287 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-backrefs.js View 1 chunk +0 lines, -53 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-ignore-case.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-ignore-case-noi18n.js View 1 chunk +0 lines, -59 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-last-index.js View 1 chunk +0 lines, -104 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-restricted-syntax.js View 1 chunk +0 lines, -44 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-unanchored-advance.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-zero-length.js View 1 chunk +0 lines, -58 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/object-literal.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regexp-string-methods.js View 2 chunks +0 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-4659.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-4665.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regress/regress-4665-2.js View 1 chunk +0 lines, -33 lines 0 comments Download
M test/mjsunit/regress/regress-5036.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-544991.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-600995.js View 1 chunk +0 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-605862.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/exception-for-nonobject.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/instance-of-immediates.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
adamk
4 years, 6 months ago (2016-06-23 23:37:25 UTC) #2
Dan Ehrenberg
https://codereview.chromium.org/2096933002/diff/20001/src/js/regexp.js File src/js/regexp.js (left): https://codereview.chromium.org/2096933002/diff/20001/src/js/regexp.js#oldcode1153 src/js/regexp.js:1153: searchSymbol, RegExpSearch, RegExpMatch and RegExpSearch are now dead code. ...
4 years, 6 months ago (2016-06-23 23:53:53 UTC) #3
adamk
https://codereview.chromium.org/2096933002/diff/20001/src/js/regexp.js File src/js/regexp.js (left): https://codereview.chromium.org/2096933002/diff/20001/src/js/regexp.js#oldcode1153 src/js/regexp.js:1153: searchSymbol, RegExpSearch, On 2016/06/23 23:53:52, Dan Ehrenberg wrote: > ...
4 years, 6 months ago (2016-06-24 00:08:27 UTC) #4
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-24 00:27:52 UTC) #5
Dan Ehrenberg
Maybe refer to the various bugs that this is removing the flag for in BUG= ...
4 years, 6 months ago (2016-06-24 00:28:08 UTC) #6
adamk
Added list of flags and bug xrefs to the CL description, thanks for the quick ...
4 years, 6 months ago (2016-06-24 00:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096933002/40001
4 years, 6 months ago (2016-06-24 00:46:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-24 01:11:19 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 01:13:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c7eb436d09d5fa10ef41a3312edea2d7a2680126
Cr-Commit-Position: refs/heads/master@{#37235}

Powered by Google App Engine
This is Rietveld 408576698