Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2096923002: Revert of Fix touchpad gesture routing to renderers (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix touchpad gesture routing to renderers (patchset #5 id:80001 of https://codereview.chromium.org/2034213002/ ) Reason for revert: Looks like this broke SitePerProcessBrowserTest.ScrollEventToOOPIF: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/55042 Original issue's description: > Fix touchpad gesture routing to renderers > > With the addition for touchpad pinch zoom, we will have gesture events > with touchpad as the source device. RenderWidgetHostInputEventRouter > should handle these types of gestures properly. > > BUG=410580 > > Committed: https://crrev.com/c6cf0184697c9b473b78cdc0e44490a73da95486 > Cr-Commit-Position: refs/heads/master@{#401723} TBR=creis@chromium.org,sadrul@chromium.org,tdresser@chromium.org,mohsen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410580 Committed: https://crrev.com/6a2a352dc06c8d616719fe94e6ff53bad26b1d88 Cr-Commit-Position: refs/heads/master@{#401753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -230 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.h View 3 chunks +10 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 5 chunks +63 lines, -108 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 3 chunks +28 lines, -105 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Created Revert of Fix touchpad gesture routing to renderers
4 years, 6 months ago (2016-06-23 23:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096923002/1
4 years, 6 months ago (2016-06-23 23:24:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 23:25:46 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 23:27:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a2a352dc06c8d616719fe94e6ff53bad26b1d88
Cr-Commit-Position: refs/heads/master@{#401753}

Powered by Google App Engine
This is Rietveld 408576698