third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js - Issue 2096903002: Revert of [Polymer] update polymer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js

Issue 2096903002: Revert of [Polymer] update polymer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json ('k') | third_party/polymer/v1_0/components-chromium/iron-pages/bower.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js

diff --git a/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js b/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js

index c592af26a0c4458429dd1ade9df1a320ff6208ea..dc46523f23206eda72c222635f73a20f970e4d21 100644

--- a/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js

+++ b/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js

@@ -312,7 +312,6 @@

* Returns the deepest overlay in the path.

* @param {Array<Element>=} path

* @return {Element|undefined}

- * @suppress {missingProperties}

* @private

_overlayInPath: function(path) {

@@ -370,11 +369,12 @@

* @param {!Element} overlay1

* @param {!Element} overlay2

* @return {boolean}

- * @suppress {missingProperties}

* @private

_shouldBeBehindOverlay: function(overlay1, overlay2) {

- return !overlay1.alwaysOnTop && overlay2.alwaysOnTop;

+ var o1 = /** @type {?} */ (overlay1);

+ var o2 = /** @type {?} */ (overlay2);

+ return !o1.alwaysOnTop && o2.alwaysOnTop;

}

};